Skip to content
L1 contracts CI

feat(EVM): Cleanup in system contracts #4517

Sign in to view logs

feat(EVM): Cleanup in system contracts

feat(EVM): Cleanup in system contracts #4517

Triggered via pull request November 29, 2024 15:40
@0xVolosnikov0xVolosnikov
opened #1103
evm-eulator/cleanup-in-system-contracts
Status Failure
Total duration 5m 18s
Artifacts –

l1-contracts-ci.yaml

on: pull_request
build
3m 51s
build
lint
55s
lint
check-verifier-generator
5m 5s
check-verifier-generator
test-foundry
0s
test-foundry
test-hardhat
0s
test-hardhat
coverage
0s
coverage
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 5 warnings
lint: l1-contracts/contracts/state-transition/l2-deps/ISystemContext.sol#L5
imported name AllowedBytecodeTypes is not used
lint: system-contracts/contracts/abstract/SystemContractBase.sol#L6
imported name ACCOUNT_CODE_STORAGE_SYSTEM_CONTRACT is not used
lint: system-contracts/contracts/ContractDeployer.sol#L239
Provide an error message for require
lint: system-contracts/contracts/ContractDeployer.sol#L239
GC: Use Custom Errors instead of require statements
lint: system-contracts/contracts/ContractDeployer.sol#L240
Provide an error message for require
lint: system-contracts/contracts/ContractDeployer.sol#L240
GC: Use Custom Errors instead of require statements
lint: system-contracts/contracts/ContractDeployer.sol#L412
Named parameters missing. MIN unnamed argumenst is 4
lint: system-contracts/contracts/ContractDeployer.sol#L425
Provide an error message for require
lint: system-contracts/contracts/ContractDeployer.sol#L425
GC: Use Custom Errors instead of require statements
lint: system-contracts/contracts/ContractDeployer.sol#L426
Provide an error message for require
lint: system-contracts/contracts/ContractDeployer.sol#L182
Avoid to use tx.origin
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/