Skip to content
System contracts CI

feat(EVM): Simplify returngas from constructor #4322

Sign in to view logs

feat(EVM): Simplify returngas from constructor

feat(EVM): Simplify returngas from constructor #4322

Triggered via pull request October 28, 2024 07:45
@0xVolosnikov0xVolosnikov
opened #1037
evm-emulator/simplify-returngas-from-constructor
Status Failure
Total duration 4m 56s
Artifacts –

system-contracts-ci.yaml

on: pull_request
build
4m 2s
build
lint
1m 13s
lint
check-hashes
32s
check-hashes
test-bootloader
0s
test-bootloader
test-contracts
0s
test-contracts
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 4 warnings
lint: l1-contracts/contracts/bridge/L1SharedBridge.sol#L133
GC: Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1SharedBridge.sol#L177
GC: Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1SharedBridge.sol#L279
GC: Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1SharedBridge.sol#L280
GC: Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1SharedBridge.sol#L290
GC: Use Custom Errors instead of require statements
lint: l1-contracts/contracts/state-transition/l2-deps/ISystemContext.sol#L5
imported name AllowedBytecodeTypes is not used
lint: system-contracts/contracts/abstract/SystemContractBase.sol#L6
imported name ACCOUNT_CODE_STORAGE_SYSTEM_CONTRACT is not used
lint: system-contracts/contracts/ContractDeployer.sol#L234
Provide an error message for require
lint: system-contracts/contracts/ContractDeployer.sol#L234
GC: Use Custom Errors instead of require statements
lint: system-contracts/contracts/ContractDeployer.sol#L235
Provide an error message for require
check-hashes
Process completed with exit code 1.
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint: system-contracts/contracts/ContractDeployer.sol#L175
Avoid to use tx.origin
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/cache/save@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
check-hashes
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/cache/restore@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/