Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PayloadVersion to the genesis. #122

Closed
wants to merge 1 commit into from
Closed

Conversation

pompon0
Copy link
Contributor

@pompon0 pompon0 commented Jun 10, 2024

It will allow us to upgrade the payload encoding in zksync-era.
This is just one solution, alternatives are:

  1. allow to actually include custom data in consensus Genesis, not just a version number.
  2. same as 1, except we include just a hash of the custom data.
  3. bump the zksync-era protocol version instead. That might be even preferrable, however I don't know whether we can afford bumping protocol version just for that.

@pompon0 pompon0 requested a review from brunoffranca June 10, 2024 15:48
@brunoffranca
Copy link
Member

Option 3 would indeed be preferable. Why do you think we can't bump protocol version for this? And I can't imagine that the encoding will change that often.

@pompon0 pompon0 closed this Jun 11, 2024
@pompon0
Copy link
Contributor Author

pompon0 commented Jun 11, 2024

we will go with zksync-era ProtocolVersion instead

@brunoffranca brunoffranca deleted the gprusak-payload-version branch July 2, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants