Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled support for inactive validators. #114

Merged
merged 7 commits into from
May 20, 2024
Merged

Conversation

pompon0
Copy link
Contributor

@pompon0 pompon0 commented May 16, 2024

We need to be able to configure a node to be a validator BEFORE it is added to the validator committee so that there is no downtime.

@pompon0 pompon0 requested a review from brunoffranca May 16, 2024 13:27
@pompon0 pompon0 requested a review from moshababo May 16, 2024 14:30
node/actors/executor/src/lib.rs Show resolved Hide resolved
Copy link
Member

@brunoffranca brunoffranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any way of the node switching from inactive to active though. It would require a restart.

@pompon0 pompon0 merged commit 3e6f101 into main May 20, 2024
5 checks passed
@pompon0 pompon0 deleted the gprusak-ignore-inactive branch May 20, 2024 15:40
github-merge-queue bot pushed a commit to matter-labs/zksync-era that referenced this pull request May 21, 2024
I need matter-labs/era-consensus#114 to be
included, so start testing EN validator mode (on stage).
github-merge-queue bot pushed a commit to matter-labs/zksync-era that referenced this pull request May 21, 2024
I need matter-labs/era-consensus#114 to be
included, so start testing EN validator mode (on stage).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants