Dreamerクラスの実装 #47
Merged
Dreamerクラスの実装 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unnecessary docstrings
…unnecessary docstrings
Geson-anko
commented
Jan 28, 2023
src/models/dreamer.py
Outdated
Comment on lines
203
to
204
| device = self.agent.hidden.device | ||
| dtype = self.agent.hidden.dtype |
There was a problem hiding this comment.
Suggested change
| device = self.agent.hidden.device | |
| dtype = self.agent.hidden.dtype | |
| device = self.device | |
| dtype = self.dtype |
src/models/abc/world.py
Outdated
| @@ -45,7 +45,7 @@ def forward( | |||
| next_obs: _tensor_or_any, | |||
| *args: Any, | |||
| **kwds: Any, | |||
| ) -> tuple[_dist_or_any, _dist_or_any, _tensor_or_any]: | |||
| ) -> tuple[_dist_or_any, _dist_or_any, _tensor_or_any, _tensor_or_any]: | |||
There was a problem hiding this comment.
ここの変更は何によって生まれたのでしょうか？
Suggested change
| ) -> tuple[_dist_or_any, _dist_or_any, _tensor_or_any, _tensor_or_any]: | |
| ) -> tuple[_dist_or_any, _dist_or_any, _tensor_or_any]: |
There was a problem hiding this comment.
記憶にない変更です...（？？）
もとに戻しておきます
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
#32 #33 TrainerとDreamerの実装ブランチです。
Dreamerのクラスの実装のみ完了しました。
変更内容
影響範囲
上記ファイル
trainer.pyはdreamer.pyに依存します
Submit前の確認項目
pytestまたはmake testコマンドでローカルにテストしましたか?pre-commit run -aまたはmake formatコマンドでpre-commitフックを実行しましたか?補足