python-sdk documentation update #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csadorf
reviewed
Aug 23, 2022
docs/source/jupyter/sdk.ipynb
Outdated
| "class MyMarketPlaceApp(MarketPlaceApp):\n", | ||
| " def heartbeat(self) -> str:\n", | ||
| "from marketplace.app.v0 import MarketPlaceApp\r\n", | ||
| "class MyMarketPlaceApp(MarketPlaceApp):\r\n", |
There was a problem hiding this comment.
Still not sure whether this is a good idea, but then we probably have to provide some kind of app_type parameter or so to the get_app() function.
singhpranjali
force-pushed
the
sdk-documentation-update
branch
from
3f3248c to
c86cf93
Compare
for more information, see https://pre-commit.ci
csadorf
requested changes
Aug 24, 2022
docs/source/jupyter/sdk.ipynb
Outdated
| "In order to easily and effectively communicate with a registered application in MarketPlace via Python, the Python Software Development Kit (SDK) can be used. Follow the instructions on the [application registration](../apps/registration.md) page to register an application with MarketPlace. Once the application is registered, you will find the `client_id` in the registration output.\n", | ||
| "\n", | ||
| "# MarketPlace SDK\r\n", | ||
| "\r\n", |
There was a problem hiding this comment.
It seems like this PR is introducing mixed line endings (\r\n vs \n). I thought that the mixed-line-ending pre-commit hook should fix that, but it does not seem to be the case. Can you briefly look into that?
Co-authored-by: Carl Simon Adorf <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Carl Simon Adorf <[email protected]>
pablo-de-andres
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #26