done #1392
done #1392
Conversation
There was a problem hiding this comment.
Great job on implementing the SalaryInfo class! 🎉 Your code meets all the task requirements and constraints, and it's well-structured and readable. The only suggestion is to consider renaming the getSalesByName method to something more descriptive like calculateSalariesByName to better reflect its functionality. Keep up the excellent work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| String[] splitData = datum.split(" "); | ||
| LocalDate dataNow = LocalDate.parse(splitData[0], formatter); | ||
| if ((dataFrom.isBefore(dataNow) || dataFrom.isEqual(dataNow)) && (dataTo.isAfter(dataNow) || dataTo.isEqual(dataNow))) { | ||
| getSalesByName(names, splitData, salariesByName); |
There was a problem hiding this comment.
The method name getSalesByName is misleading as it suggests retrieving sales data, but it actually calculates salaries. Consider renaming it to something like calculateSalariesByName to better reflect its purpose.
| String[] data, | ||
| String dateFrom, | ||
| String dateTo) { | ||
| final DateTimeFormatter formatter = DateTimeFormatter |
| private static void calculateSalariesByName(String[] names, | ||
| String[] splitData, | ||
| int[] salariesByName) { | ||
| for (int j = 0; j < names.length; j++) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
Maybe you can give me a small hint how i can reduse loops count? Cuz i honestly have no idea how to remove one of that loops
| int[] salariesByName) { | ||
| for (int j = 0; j < names.length; j++) { | ||
| if (splitData[1].equals(names[j])) { | ||
| int countOfHours = Integer.parseInt(splitData[2]); |
There was a problem hiding this comment.
let's create constants for all magic numbers
There was a problem hiding this comment.
You say about numbers 1 and 2?
No description provided.