homework done #1778
Open
homework done #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Jan 7, 2025
| package core.basesyntax; | ||
|
|
||
| public interface Drawable { | ||
| double area(); |
There was a problem hiding this comment.
Drawable should be responsible only to draw information
create AreaCalculator interface to calculate area
Comment on lines
13
to
18
| @Override | ||
| public abstract double area(); | ||
|
|
||
| // Abstract method to draw the figure (implemented in subclasses) | ||
| @Override | ||
| public abstract void draw(); |
There was a problem hiding this comment.
Suggested change
| @Override | |
| public abstract double area(); | |
| // Abstract method to draw the figure (implemented in subclasses) | |
| @Override | |
| public abstract void draw(); |
| Figure[] figures = new Figure[FIGURE_COUNT]; | ||
|
|
||
|
|
||
| for (int i = 0; i < 3; i++) { |
|
|
||
| public class Main { | ||
| public static void main(String[] args) { | ||
| final int FIGURE_COUNT = 5; |
Elena-Bruyako
suggested changes
Jan 7, 2025
|
|
||
| @Override | ||
| public double area() { | ||
|
|
| package core.basesyntax; | ||
|
|
||
| public interface AreaCalculator { | ||
| double area(); |
There was a problem hiding this comment.
Suggested change
| double area(); | |
| double getArea(); |
| package core.basesyntax; | ||
|
|
||
| public interface Drawable { | ||
|
|
| private Color color; | ||
|
|
||
| public Figure(Color color) { | ||
|
|
| } | ||
|
|
||
| public Color getColor() { | ||
|
|
| switch (type) { | ||
| case 0: | ||
| return new Square( | ||
| random.nextInt(MAX_DIMENSION) + 1, |
There was a problem hiding this comment.
create separate method for getting random.nextInt(MAX_DIMENSION) + 1
| Figure[] figures = new Figure[FIGURE_COUNT]; | ||
|
|
||
|
|
||
| for (int i = 0; i < 3; i++) { |
|
|
||
| @Override | ||
| public double area() { | ||
|
|
|
|
||
| @Override | ||
| public double area() { | ||
|
|
|
|
||
| @Override | ||
| public double area() { | ||
|
|
liliia-ponomarenko
suggested changes
Jan 8, 2025
| package core.basesyntax; | ||
|
|
||
| public interface AreaCalculator { | ||
| double area(); |
Comment on lines
+15
to
+20
|
|
||
| @Override | ||
| public abstract double area(); | ||
|
|
||
| @Override | ||
| public abstract void draw(); |
| getRandomDimension(), | ||
| color); | ||
| default: | ||
| return null; |
There was a problem hiding this comment.
don't return null from the method. Use some figures for the default case
| + height + " units, color: " + getColor()); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
leave only one empty line at the end of the file (check other file)
liliia-ponomarenko
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.