Speedup analysis #105
Merged
Speedup analysis #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oussama-floor9
commented
Jul 12, 2024
•
oussama-floor9
commented
- closes Parareal speedup analysis #96 update time.sh and lorenz_parallel.py + add results for speedup analysis
- closes fix tests pytest #91
prudhomm
approved these changes
Jul 15, 2024
| @@ -60,7 +60,7 @@ jobs: | |||
|
|
|||
| - name: Run standard tests | |||
| run: | | |||
| pytest | |||
| pytest ./tests | |||
There was a problem hiding this comment.
pytest should be able to find automatically the tests in subdirectories
why did you have to add ./tests ?
do you have other directories with tests ?
There was a problem hiding this comment.
Yes it should be automatically but, when the tests are running it gives me an error with files that are not belong to /tests
- No it is the only directory for tests
notebooks/python/execution_times.txt
Outdated
There was a problem hiding this comment.
It may be a good idea to rename the output data file and add a date and time in the name ?
There was a problem hiding this comment.
Ok i will rename it and add the date time
notebooks/python/lorenz_parallel.py
Outdated
| @@ -15,11 +15,11 @@ | |||
| # Model parameters | |||
| sigma, rho, beta = 10.0, 28.0, 8/3 | |||
| U0 = np.array([5, -5, 20]) | |||
| tspan = [0., 5.] | |||
| tspan = [0., 10.] | |||
| lorenz_ = lambda t, state: lorenz(t, state, sigma, rho, beta) | |||
|
|
|||
| # Parareal params | |||
There was a problem hiding this comment.
please update the comment or use a clearer name !
There was a problem hiding this comment.
N is the number of sub-intervals
prudhomm
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.