feat: replaces noop store with memory store #29
+29
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table of Contents
Description
This implements a basic memory store instead of noop.
Motivation and Context
When server-side rendering, having a noop store causes
useExperiment
calls to fail even if they were made after aemitter.defineVariants
call.How Has This Been Tested?
I've added tests to store.jsx to check if it could set and get items from it. The most important part is to delete
window.localStorage
and keep it working properly.Screenshots (if appropriate):
Types of changes
Checklist: