Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit more ID3 tags (#732) #805

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Edit more ID3 tags (#732) #805

merged 7 commits into from
Dec 5, 2024

Conversation

martpie
Copy link
Owner

@martpie martpie commented Dec 4, 2024

Replaces #791

Kinda impersonated @igorer88 for the commit, but I hope you don't mind.

@igorer88
Copy link
Contributor

igorer88 commented Dec 4, 2024

Ohh no no. I got absorbed with the moving trip. I couldn't put as much effort as I wanted. Thanks for the commit.

@martpie
Copy link
Owner Author

martpie commented Dec 4, 2024

Don't worry, the rebase was pure hell anyway, you would have probably ragequit on it haha

@martpie
Copy link
Owner Author

martpie commented Dec 5, 2024

Thank you @igorer88, I'll leave you check if you want to tackle the ID3 edition on disk, but we should be good for now and it's already a win.

@martpie martpie merged commit 3cfab9f into master Dec 5, 2024
4 checks passed
@martpie martpie deleted the more-id3-edit branch December 5, 2024 00:04
@igorer88
Copy link
Contributor

igorer88 commented Dec 5, 2024

I like that option. I could really make use of that feature hehe. So I would continue. I have some of it ready in the git stash I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants