Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite #795

Merged
merged 6 commits into from
Nov 2, 2024
Merged

SQLite #795

merged 6 commits into from
Nov 2, 2024

Conversation

martpie
Copy link
Owner

@martpie martpie commented Oct 31, 2024

Fixes #793

via the awesome ormlite.

@martpie
Copy link
Owner Author

martpie commented Nov 1, 2024

Got a working version, 4000 tracks load in 50ms. Insertion and deletions don't need transactions (inserting all 4000 tracks sequentially is almost instant).

Looking good so far :) Some weird edgecases though with ormlite, stuff not well exposed, but so far so good.

@martpie
Copy link
Owner Author

martpie commented Nov 2, 2024

Erratum: inserting 4000 tracks take 2 seconds, which is good enough. Deleting and vacuuming takes 5 sevconds clearing the records one by one, so I just used one statement to delete everything, which is instant, but less type safe

- Fix get_tracks()
- Use table_name() when possible
- Remove un-needed migration file
- Add missing index on Track's path
- Remove outdated comment
@martpie martpie changed the title [WIP] SQLite SQLite Nov 2, 2024
@martpie martpie merged commit f6bbbbe into master Nov 2, 2024
4 checks passed
@martpie martpie deleted the sqlite branch November 2, 2024 23:23
igorer88 pushed a commit to igorer88/museeks that referenced this pull request Nov 29, 2024
* Play with ormlite

* Make ormlite work

* Cleanup code, deps and reimplement reset

* Misc SQLite fixes

- Fix get_tracks()
- Use table_name() when possible
- Remove un-needed migration file

* Additional SQLite fixes

- Add missing index on Track's path
- Remove outdated comment

* Remove duplicate handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate DB to SQLite
1 participant