Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API documentation and build #72

Merged
merged 9 commits into from
Aug 9, 2021
Merged

Fix API documentation and build #72

merged 9 commits into from
Aug 9, 2021

Conversation

auroracramer
Copy link
Collaborator

Fix image embedding size in load_image_embedding_model() docstring, mock missing tensorflow.keras modules in doc/conf.py to fix API documentation build, and remove pin on sphinx version. Addresses #60 and #71.

@hohsiangwu
Copy link
Collaborator

Looks like the test failures are related to import skimage vs import skimage.transform as in here

Not sure if it is because skimage version is upgraded since we remove the limits on the version. Though why it's not failing in the previous build?

@hohsiangwu
Copy link
Collaborator

Except for the failing tests, other changes look good to me!

@auroracramer
Copy link
Collaborator Author

Thanks for taking a look into the build issues and finding this! I made an issue for it here: #73 and I'll merge in a fix to this branch.

@auroracramer
Copy link
Collaborator Author

auroracramer commented Aug 8, 2021

As far why it didn't fail last time, it looks like it was because the last build to run was on May 29th, which was right before the travis-ci.org shutdown on May 31st. This repository was only recently migrated to travis-ci.com, so it looks that's why the change in skimage only appeared in this PR and when I renamed the main branch. What amazing timing 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants