Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ciphers #573

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat: add ciphers #573

wants to merge 8 commits into from

Conversation

boorad
Copy link
Collaborator

@boorad boorad commented Jan 3, 2025

Add Ciphers functionality

@boorad boorad self-assigned this Jan 3, 2025
renanmav
renanmav reviewed Jan 15, 2025
View reviewed changes
package.json
"start": "bun --filter='react-native-quick-crypto-example' start",
"start": "cd example && bun start",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use --filter flag anymore?

should other commands also be updated?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I do bun start from top level (not in example folder), the command with --filter rolls through 10 lines and truncates. This way, I see all the history in the terminal. The others don't need to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renanmav renanmav renanmav left review comments

Assignees

@boorad boorad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boorad @renanmav