This repository has been archived by the owner on May 17, 2022. It is now read-only.
WIP: adding media-initial commit #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcog83
suggested changes
Mar 12, 2022
| @@ -8,6 +8,9 @@ const renderImage = (ctx, node) => { | |||
| const {style, options, box } = node; | |||
| ctx.addImage({...options,...style,...box}); | |||
| }; | |||
| const renderMedia = (ctx, node) => { | |||
| ctx.addMedia(node.props); | |||
There was a problem hiding this comment.
You can see how other functions deal with the parameters, and copy it.
the the idea is that style and box are properties for positioning and sizing, and options contains all other props.
options is supposed to be created in styleMedia function
const {style, options, box } = node;
ctx.addMedia({...options,...style,...box});
apart from this, great job, you properly get how to create new primitive.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not review and merge yet.