-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify how to express an unmapped entity using sssom:NoTermFound #381
Conversation
In addition to the model entry, the feature is documented in the model specification. As usual, we add examples and link to the corresponding issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you wrote is fine for the documentation, but not for the spec IMO.
All the spec should do is warn implementers that they may come across the sssom:NoTermFound
value, how they should interpret it, and what constraints apply to mappings where this value is used.
Thanks @gouttegd for these suggestions!
Two questions:
Such a mapping could be used to explicitly indicate that two domains (vocabularies, ontologies, databases, whatever) are completely disjoint and have nothing in common. I suppose this would be a very infrequent need, but a priori I see no reason to forbid that.
Consider the following mapping (justification omitted for brevity):
Applying the classic inversion rules, this would be inverted into:
I think this is fine: the first mapping says “HP:1234 has no narrow match in MP”, the second says “nothing in MP has a broad match to HP:1234” – this seems correct to me, what do you think? |
I like the thinking. Do you think we should add this as a comment to the spec?
Thank you for thinking of this! The example makes me was hard to think through mentally, but I think you are right, there is no problem. If HP:123 does not have a narrow match in MP, No term in MP can be a broad match to it. |
To the user-facing documentation, maybe. To the spec, no need, there’s nothing that implementations should be aware of. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run make all
same as #386 (review)
Co-authored-by: Emily Hartley <[email protected]>
Fixes #28
In the PR we add the ability to express that an entity in a mapping does not have a corresponding mappable entity.
In addition to the model entry, the feature is documented in the model specification.
As usual, we add examples and link to the corresponding issue.
docs/
have been added/updated if necessarymake test
has been run locallytests have been added/updated (if applicable)If you are proposing a change to the SSSOM metadata model, you must
examples/
see_also
field of the linkml modelsee_also
field of the linkml model