Model propagatable slots #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a "propagated" annotation to all slots that should be considered "propagatable", that is, all slots that, when set at the level of the mapping set, can (and should) be propagatated down to the level of individual mappings. The presence of the annotation in the model replaces the list available in the src/docs/spec-model.md document as the authoritative source for which slots are propatagable or not. The aforementioned list remains in place, but only as a convenience for readers of the spec.
Update the section about "propagatable slots" to refer to the LinkML model, and the newly added "propagated" annotation, as the source of truth for which slots are considered propagatable.
Mention the newly added concept of "propagatable slots" in the CHANGELOG for the next release. Also fix the CHANGELOG, that didn't contain an entry for the last two releases.
gouttegd
added
enhancement
matentzn
reviewed
Jul 19, 2024
matentzn
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves [#305]
docs/have been added/updated if necessarymake testhas been run locallyIf you are proposing a change to the SSSOM metadata model, you must
examples/(not applicable: no new example needed as the change only affects how some slots should be interpreted; it does not add or remove slots, nor does it change how the propagated slots are used)see_alsofield of the linkml modelsee_alsofield of the linkml model (not applicable, same reason as above)This PR finalises the fix to #305, by explicitly specifying, directly within the LinkML model, which slots are considered “propagatable” (previously this was only informally described in the spec, since #368). This is done by:
sssom:Propagatable) with a single boolean-ranged attributedpropagated;sssom:Propagatableextension.