Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poetry.lock back to versioning and trying minimal dependency #400

Merged
merged 35 commits into from
Aug 1, 2023

Conversation

hrshdhgd
Copy link
Contributor

@hrshdhgd hrshdhgd commented Jul 27, 2023

  • Added poetry.lock back to version control

  • Removed pinning of poetry version in GitHub Actions

  • Pruned dependency list to the minimal required one based on the dependencies that already bring in other packages that are needed.

  • figure out why the error was occurring:

    • So linkml-runtime has a dependency on prefixcommons which has a dependency on pytest-logging. This package (pytest-logging) is causing issues with the windows instance within GitHub Actions.
    • I do not know why this is not happening in any of the other projects we have.
    • The fix in qc.yml is :
      poetry run pip wheel --use-pep517 "pytest-logging (==2015.11.4)"
    

    before poetry install

  • Another issue was with Windows environment not detecting poetry as a command in spite of being installed.

    • Reason: poetry path was not automatically being added to environment variables when it is invoked using an reusable gh-action ( snok/install-poetry@v1).
    • Fix:
    - name: Windows specific step.
            if: matrix.os == 'windows-latest'
            run: echo "${HOME}/.local/bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
    
    
  • pyparsing is not really used in the project as far as I know. It is also causing errors in GH Actions. So removing it

Note: poetry is still pinned to version 1.3.2 as before.

@hrshdhgd hrshdhgd changed the title Add poetry.lock to versioning and trying minimal dependency Add poetry.lock back to versioning and trying minimal dependency Jul 27, 2023
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
.github/workflows/qc.yml Outdated Show resolved Hide resolved
.github/workflows/qc.yml Outdated Show resolved Hide resolved
@hrshdhgd hrshdhgd marked this pull request as ready for review July 31, 2023 23:13
@hrshdhgd hrshdhgd requested a review from matentzn July 31, 2023 23:16
Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hrshdhgd hrshdhgd merged commit 8a98cf5 into master Aug 1, 2023
6 checks passed
@hrshdhgd hrshdhgd deleted the test-min-dependency branch August 1, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants