-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add poetry.lock back to versioning and trying minimal dependency #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrshdhgd
changed the title
Add poetry.lock to versioning and trying minimal dependency
Add poetry.lock back to versioning and trying minimal dependency
Jul 27, 2023
cthoyt
reviewed
Jul 28, 2023
matentzn
reviewed
Jul 29, 2023
matentzn
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
poetry.lock
back to version controlRemoved pinning of poetry version in GitHub ActionsPruned dependency list to the minimal required one based on the dependencies that already bring in other packages that are needed.figure out why the error was occurring:
linkml-runtime
has a dependency onprefixcommons
which has a dependency onpytest-logging
. This package (pytest-logging) is causing issues with the windows instance within GitHub Actions.qc.yml
is :before
poetry install
Another issue was with Windows environment not detecting
poetry
as a command in spite of being installed.poetry
path was not automatically being added to environment variables when it is invoked using an reusable gh-action (snok/install-poetry@v1
).pyparsing
is not really used in the project as far as I know. It is also causing errors in GH Actions. So removing itNote:
poetry
is still pinned to version 1.3.2 as before.