Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile-metrics v2 android-navigation-binary-size #7890

Open
wants to merge 2 commits into
base: lts/v2
Choose a base branch
from

Conversation

Guardiola31337
Copy link
Contributor

Description

Follow-up from #7889

Fixes mobile-metrics v2 android-navigation-binary-size

Screenshots or Gifs

@Guardiola31337 Guardiola31337 added the skip changelog Should not be added into version changelog. label Nov 26, 2024
@Guardiola31337 Guardiola31337 self-assigned this Nov 26, 2024
@Guardiola31337 Guardiola31337 requested a review from a team as a code owner November 26, 2024 15:46
Copy link

Changelog

Features

  • The PredictiveCacheController(PredictiveCacheOptions) constructor is now deprecated. Use PredictiveCacheController(MapboxNavigation, PredictiveCacheOptions) instead. [#7856](https://github.com/mapbox/mapbox-navigation-android/pull/7856)
  • Optimized memory usage in Directions API model classes by interning frequently occurring strings in JSON. [#7840](https://github.com/mapbox/mapbox-navigation-android/pull/7840)

Bug fixes and improvements

  • Fixed UI jank caused by on-device TextToSpeech player. [#7833](https://github.com/mapbox/mapbox-navigation-android/pull/7833)
  • Fixed an issue where native memory was not being properly released after the MapboxNavigation object was destroyed. [#7856](https://github.com/mapbox/mapbox-navigation-android/pull/7856)

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

  • The app is now considered as the one in active navigation only when an active route is set to MapboxNavigation. Previously it was always considered active. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)
  • When Android Auto host tells the app to stop active navigation because another app starts navigating, now SDK will enter FreeDrive mode instead of stopping trip session completely. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)

@Guardiola31337 Guardiola31337 enabled auto-merge (squash) November 26, 2024 15:48
@Guardiola31337 Guardiola31337 force-pushed the pg-fix-android-nav-binary-size branch from fb1710a to 44c9e11 Compare November 26, 2024 16:32
@Guardiola31337
Copy link
Contributor Author

Fixed some androidauto-test CI issues https://discuss.circleci.com/t/android-image-deprecations-and-eol-for-2024/50180/12 although now I'm running into Gradle ones 😬

BUILD FAILED in 5s
Starting test attempt 2

FAILURE: Build failed with an exception.

* What went wrong:
Could not open settings generic class cache for settings file '/home/circleci/project/settings.gradle' (/home/circleci/.gradle/caches/7.5.1/scripts/f2ft64juee2bwqj08kpzg70c1).
> BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 65

cc @RingerJK

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.10%. Comparing base (697488a) to head (44c9e11).

Impacted file tree graph

@@            Coverage Diff            @@
##             lts/v2    #7890   +/-   ##
=========================================
  Coverage     74.10%   74.10%           
  Complexity     6260     6260           
=========================================
  Files           856      856           
  Lines         33809    33809           
  Branches       4027     4027           
=========================================
  Hits          25053    25053           
  Misses         7199     7199           
  Partials       1557     1557           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Should not be added into version changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants