NAVAND-2991 - Optimized TextToSpeech usage #7833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved language setting and speak calls to a background thread.
ChangelogFeaturesBug fixes and improvements
Known issues
|
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #7833 +/- ##
=========================================
Coverage 74.16% 74.17%
+ Complexity 6265 6262 -3
=========================================
Files 856 856
Lines 33779 33789 +10
Branches 4023 4023
=========================================
+ Hits 25053 25062 +9
- Misses 7168 7170 +2
+ Partials 1558 1557 -1
|
DSamaryan
approved these changes
Jun 21, 2024
DzmitryFomchyn
pushed a commit
that referenced
this pull request
Jul 22, 2024
* NAVAND-2991 - Optimized TextToSpeech usage Moved language setting and speak calls to a background thread. * Rename changelog files * NAVAND-2991 - Optimized TextToSpeech usage Unit-test fix --------- Co-authored-by: runner <runner@fv-az1428-633>
DzmitryFomchyn
added a commit
that referenced
this pull request
Jul 22, 2024
* NAVAND-2991 - Optimized TextToSpeech usage Moved language setting and speak calls to a background thread. * Rename changelog files * NAVAND-2991 - Optimized TextToSpeech usage Unit-test fix --------- Co-authored-by: Tomasz Rybakiewicz <[email protected]> Co-authored-by: runner <runner@fv-az1428-633>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
NAVAND-2991
Description
Backporting v3 optimization https://github.com/mapbox/navigation/pull/5638
NavSDK 2.0 traces captured from "examples > Voice Example" activity running on Android Emulator.
TextToSpeechProvider.getTextToSpeech(...)21ms30msVoiceInstructionsTextPlayer.initializeWithLanguage(...)207ms508mstextToSpeech.speak(...)25ms1ms15ms1msI've moved both
initializeWithLanguage(...)andtextToSpeech.speak(...)calls to the background thread to optimize this. Additionally, I've updated the "examples > Voice Example" activity to initializeMapboxVoiceInstructionsPlayeroff the main thread. The optimized execution time slightly increased due to lesser background thread prioritization.navsdk-cpu-perfetto.baseline.trace.zip
navsdk-cpu-perfetto.optimized.trace.zip