Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addressed comments from #7744 #7745

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

LukasPaczos
Copy link

Description

#7744 follow up.

@LukasPaczos LukasPaczos requested a review from a team as a code owner February 8, 2024 10:29
@LukasPaczos LukasPaczos added the skip changelog Should not be added into version changelog. label Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

Changelog

Features

Bug fixes and improvements

Known issues ⚠️

Other changes

  • Added Polish translation for UI elements.
Android Auto Changelog

Features

Bug fixes and improvements

  • The app is now considered as the one in active navigation only when an active route is set to MapboxNavigation. Previously it was always considered active. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)
  • When Android Auto host tells the app to stop active navigation because another app starts navigating, now SDK will enter FreeDrive mode instead of stopping trip session completely. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)

Comment on lines 2 to 8
<resources>
<!-- Indicates voice instructions are muted -->
<string name="mapbox_muted">Wyciszony</string>
<string name="mapbox_muted">Dźwięk wył.</string>

<!-- Indicates voice instructions are unmuted -->
<string name="mapbox_unmuted">Niewyciszony</string>
<string name="mapbox_unmuted">Dźwięk wł.</string>
</resources>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen_recording_20240208_112727.mp4

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azarovalex please have a look in here.
It might be better translation then the one I've provided.

    mapbox_muted = Dźwięk wył.
    mapbox_unmuted = Dźwięk wł.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7054ed8) 74.11% compared to head (8d0a727) 74.11%.
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #7745   +/-   ##
=========================================
  Coverage     74.11%   74.11%           
  Complexity     6252     6252           
=========================================
  Files           852      852           
  Lines         33672    33672           
  Branches       4011     4011           
=========================================
  Hits          24955    24955           
  Misses         7167     7167           
  Partials       1550     1550           

Copy link

@holuss holuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@LukasPaczos LukasPaczos merged commit 56332c6 into main Feb 8, 2024
41 of 45 checks passed
@LukasPaczos LukasPaczos deleted the lp/polish-translations-follow-up branch February 8, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Should not be added into version changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants