Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make parsing safer #7668

Merged
merged 2 commits into from
Dec 13, 2023
Merged

make parsing safer #7668

merged 2 commits into from
Dec 13, 2023

Conversation

dzinad
Copy link
Contributor

@dzinad dzinad commented Dec 12, 2023

CP of #7667.

@dzinad dzinad requested a review from a team as a code owner December 12, 2023 12:18
Copy link

Changelog

Features

  • Introduced RouterFailure#isRetryable which indicates if that makes sense to retry with this type of failure. [#7597](https://github.com/mapbox/mapbox-navigation-android/pull/7597)
    For convenience, you can use an extension property isRetryable for the list of RouterFailure in NavigationRouterCallback.onFailure.
    In case of reroute use RerouteState.Failed.isRetryable.
  • Introduced NavigationOptions#longRoutesOptimisationOptions which changes the Nav SDK behavior so that it's able to handle heavy routes objects. See documentation of OptimiseNavigationForLongRoutes to learn more about it. [#7564](https://github.com/mapbox/mapbox-navigation-android/pull/7564)
  • Route refresh now refreshes LegAnnotation#freeflowSpeed and LegAnnotation#currentSpeed. [#7582](https://github.com/mapbox/mapbox-navigation-android/pull/7582)

Bug fixes and improvements

  • Fixed an issue when alertcCodes and trafficCodes were lost during route refresh. [#7568](https://github.com/mapbox/mapbox-navigation-android/pull/7568)
  • Fixed backward positioning jumps after GPS signal jump detection. [#7588](https://github.com/mapbox/mapbox-navigation-android/pull/7588)
  • Improved processing of ETC signals. [#7588](https://github.com/mapbox/mapbox-navigation-android/pull/7588)
  • Supported ETC 2.0 payment method. [#7614](https://github.com/mapbox/mapbox-navigation-android/pull/7614)
  • Fixed an issue where route parsing might have crashes for invalid Directions Response. [#dd](https://github.com/mapbox/mapbox-navigation-android/pull/dd)
  • Fixed crash which sometimes happens during stopping of active guidance [#7636](https://github.com/mapbox/mapbox-navigation-android/pull/7636)
  • Optimised memory consumption of Copilot. [#7622](https://github.com/mapbox/mapbox-navigation-android/pull/7622)
  • Fixed an issue where route might have hung on reroute after a deviation had occurred. [#7651](https://github.com/mapbox/mapbox-navigation-android/pull/7651)
  • Fixed an issue where a user might have received constant off-route events and no route progress. [#7651](https://github.com/mapbox/mapbox-navigation-android/pull/7651)
  • Fixed an issue where route refreshes might not have been paused after invoking RouteRefreshController#pauseRouteRefreshes. [#7579](https://github.com/mapbox/mapbox-navigation-android/pull/7579)
  • Optimised memory and network usage. [#7555](https://github.com/mapbox/mapbox-navigation-android/pull/7555)
  • Fixed an issue when navigation could switch between alternative routes in cycle when a user moves backward. [#7626](https://github.com/mapbox/mapbox-navigation-android/pull/7626)

Known issues ⚠️

  • Seamless switch to a route alternative doesn't always work for multi legs routes, regular reroute happens instead.

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

  • The app is now considered as the one in active navigation only when an active route is set to MapboxNavigation. Previously it was always considered active. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)
  • When Android Auto host tells the app to stop active navigation because another app starts navigating, now SDK will enter FreeDrive mode instead of stopping trip session completely. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)

@dzinad dzinad force-pushed the dd-fix-parsing-exceptions-cp branch from 51f21f7 to 6246771 Compare December 12, 2023 12:33
@dzinad dzinad enabled auto-merge (rebase) December 12, 2023 12:34
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #7668 (cbf8916) into main (e927af0) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #7668   +/-   ##
=========================================
  Coverage     74.08%   74.09%           
  Complexity     6152     6152           
=========================================
  Files           833      834    +1     
  Lines         33128    33140   +12     
  Branches       3957     3952    -5     
=========================================
+ Hits          24544    24555   +11     
- Misses         7050     7051    +1     
  Partials       1534     1534           
Files Coverage Δ
...vigation/core/telemetry/events/FeedbackMetadata.kt 71.31% <ø> (ø)
...route/internal/util/DirectionsRouteRefreshUtils.kt 57.14% <100.00%> (ø)
...va/com/mapbox/navigation/ui/shield/ShieldsCache.kt 92.50% <100.00%> (+0.60%) ⬆️
...n/base/route/DirectionsResponseParsingException.kt 0.00% <0.00%> (ø)
...om/mapbox/navigation/base/route/NavigationRoute.kt 72.01% <50.00%> (-0.56%) ⬇️
...ion/base/internal/utils/DirectionsResponseUtils.kt 0.00% <0.00%> (ø)

@dzinad dzinad force-pushed the dd-fix-parsing-exceptions-cp branch 2 times, most recently from 5568020 to 2bd4a15 Compare December 12, 2023 17:03
@dzinad dzinad force-pushed the dd-fix-parsing-exceptions-cp branch from 7357bf4 to 4e8e20a Compare December 12, 2023 17:57
@dzinad dzinad merged commit 24cd749 into main Dec 13, 2023
31 of 35 checks passed
@dzinad dzinad deleted the dd-fix-parsing-exceptions-cp branch December 13, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants