NAVAND-1636: do not set routes to NN when session is already started #7661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzinad
added
the
needs backporting
ChangelogFeaturesBug fixes and improvements
Known issues
|
Comment on lines
1156
to
1164
| private fun resetTripSessionRoutes() { | ||
| threadController.getMainScopeAndRootJob().scope.launch(Dispatchers.Main.immediate) { | ||
| routeUpdateMutex.withLock { | ||
| val routes = directionsSession.routes | ||
| val legIndex = latestLegIndex ?: directionsSession.initialLegIndex | ||
| setRoutesToTripSession(routes, SetRoutes.NewRoutes(legIndex)) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I believe there were cases when the routes might have been present on the NavSDK side, but not on NN side. Or it was added just in case, because we didn't know exactly how NN works with routes.
dzinad
force-pushed
the
NAVAND-1636-dd
branch
from
a502003 to
fa64077
Compare
Codecov Report
@@ Coverage Diff @@
## release-v2.17 #7661 +/- ##
================================================
Coverage 74.08% 74.08%
Complexity 6152 6152
================================================
Files 833 833
Lines 33128 33130 +2
Branches 3957 3958 +1
================================================
+ Hits 24544 24546 +2
Misses 7050 7050
Partials 1534 1534
|
dzinad
force-pushed
the
NAVAND-1636-dd
branch
from
8660063 to
0eb686b
Compare
dzinad
changed the title
dzinad
force-pushed
the
NAVAND-1636-dd
branch
from
5d8b81f to
8c70bf5
Compare
VysotskiVadim
approved these changes
Dec 12, 2023
dzinad
force-pushed
the
NAVAND-1636-dd
branch
from
a05758f to
6438122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description is in the ticket: https://mapbox.atlassian.net/browse/NAVAND-1636?focusedCommentId=206653