-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Got rid of init route event in copilot #7622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChangelogFeatures
Bug fixes and improvements
Known issues
|
VysotskiVadim
added
the
needs backporting
Requires cherry-picking to a currently running release branch
label
Nov 16, 2023
DzmitryFomchyn
approved these changes
Nov 16, 2023
Codecov Report
@@ Coverage Diff @@
## main #7622 +/- ##
============================================
- Coverage 74.11% 74.08% -0.03%
+ Complexity 6164 6152 -12
============================================
Files 834 833 -1
Lines 33157 33128 -29
Branches 3961 3957 -4
============================================
- Hits 24574 24544 -30
Misses 7050 7050
- Partials 1533 1534 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Serialisation of long route could create additional memory pressure and cause OOM. We can remove it because history trace recorded by NN contains enough data and there is no need in initial route event.