Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got rid of init route event in copilot #7622

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

VysotskiVadim
Copy link
Contributor

Description

Serialisation of long route could create additional memory pressure and cause OOM. We can remove it because history trace recorded by NN contains enough data and there is no need in initial route event.

@VysotskiVadim VysotskiVadim requested a review from a team as a code owner November 16, 2023 11:29
Copy link

github-actions bot commented Nov 16, 2023

Changelog

Features

  • Introduced RouterFailure#isRetryable which indicates if that makes sense to retry with this type of failure. [#7597](https://github.com/mapbox/mapbox-navigation-android/pull/7597)
    For convenience, you can use an extension property isRetryable for the list of RouterFailure in NavigationRouterCallback.onFailure.
    In case of reroute use RerouteState.Failed.isRetryable.
  • Introduced NavigationOptions#longRoutesOptimisationOptions which changes the Nav SDK behavior so that it's able to handle heavy routes objects. See documentation of OptimiseNavigationForLongRoutes to learn more about it. [#7564](https://github.com/mapbox/mapbox-navigation-android/pull/7564)
  • Route refresh now refreshes LegAnnotation#freeflowSpeed and LegAnnotation#currentSpeed. [#7582](https://github.com/mapbox/mapbox-navigation-android/pull/7582)

Bug fixes and improvements

  • Fixed an issue where route refreshes might not have been paused after invoking RouteRefreshController#pauseRouteRefreshes. [#7579](https://github.com/mapbox/mapbox-navigation-android/pull/7579)
  • Supported ETC 2.0 payment method. [#7614](https://github.com/mapbox/mapbox-navigation-android/pull/7614)
  • Optimised memory consumption of Copilot. [#7622](https://github.com/mapbox/mapbox-navigation-android/pull/7622)
  • Fixed an issue when alertcCodes and trafficCodes were lost during route refresh. [#7568](https://github.com/mapbox/mapbox-navigation-android/pull/7568)
  • Optimised memory and network usage. [#7555](https://github.com/mapbox/mapbox-navigation-android/pull/7555)
  • Fixed backward positioning jumps after GPS signal jump detection. [#7588](https://github.com/mapbox/mapbox-navigation-android/pull/7588)
  • Improved processing of ETC signals. [#7588](https://github.com/mapbox/mapbox-navigation-android/pull/7588)

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

  • The app is now considered as the one in active navigation only when an active route is set to MapboxNavigation. Previously it was always considered active. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)
  • When Android Auto host tells the app to stop active navigation because another app starts navigating, now SDK will enter FreeDrive mode instead of stopping trip session completely. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)

@VysotskiVadim VysotskiVadim added the needs backporting Requires cherry-picking to a currently running release branch label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #7622 (d777331) into main (f1757f4) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #7622      +/-   ##
============================================
- Coverage     74.11%   74.08%   -0.03%     
+ Complexity     6164     6152      -12     
============================================
  Files           834      833       -1     
  Lines         33157    33128      -29     
  Branches       3961     3957       -4     
============================================
- Hits          24574    24544      -30     
  Misses         7050     7050              
- Partials       1533     1534       +1     
Files Coverage Δ
...pbox/navigation/copilot/HistoryAttachmentsUtils.kt 87.50% <100.00%> (ø)
...ava/com/mapbox/navigation/copilot/HistoryEvents.kt 100.00% <ø> (ø)
...com/mapbox/navigation/copilot/MapboxCopilotImpl.kt 88.43% <100.00%> (-1.26%) ⬇️

@VysotskiVadim VysotskiVadim merged commit d9a6a1f into main Nov 20, 2023
7 of 10 checks passed
@VysotskiVadim VysotskiVadim deleted the NAVAND-1582-got-rid-of-init-route-event branch November 20, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backporting Requires cherry-picking to a currently running release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants