Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAVAND-1546: cherry-pick to 2.17 #7601

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

VysotskiVadim
Copy link
Contributor

CP of #7597

@VysotskiVadim VysotskiVadim requested a review from a team as a code owner November 3, 2023 09:22
Copy link

github-actions bot commented Nov 3, 2023

Changelog

Features

  • Introduced RouterFailure#isRetryable which indicates if that makes sense to retry with this type of failure. [#7597](https://github.com/mapbox/mapbox-navigation-android/pull/7597)
    For convenience, you can use an extension property isRetryable for the list of RouterFailure in NavigationRouterCallback.onFailure.
    In case of reroute use RerouteState.Failed.isRetryable.

Bug fixes and improvements

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

  • The app is now considered as the one in active navigation only when an active route is set to MapboxNavigation. Previously it was always considered active. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)
  • When Android Auto host tells the app to stop active navigation because another app starts navigating, now SDK will enter FreeDrive mode instead of stopping trip session completely. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #7601 (4bdd203) into release-v2.17 (5135328) will decrease coverage by 0.01%.
The diff coverage is 61.53%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             release-v2.17    #7601      +/-   ##
===================================================
- Coverage            74.11%   74.11%   -0.01%     
  Complexity            6164     6164              
===================================================
  Files                  832      834       +2     
  Lines                33147    33157      +10     
  Branches              3959     3961       +2     
===================================================
+ Hits                 24568    24574       +6     
- Misses                7046     7050       +4     
  Partials              1533     1533              
Files Coverage Δ
.../mapbox/navigation/route/internal/RouterWrapper.kt 78.21% <100.00%> (+0.55%) ⬆️
...vigation/base/internal/route/RetryableThrowable.kt 0.00% <0.00%> (ø)
.../java/com/mapbox/navigation/base/route/RouterEx.kt 0.00% <0.00%> (ø)
...apbox/navigation/core/reroute/RerouteController.kt 90.90% <66.66%> (-9.10%) ⬇️
...in/java/com/mapbox/navigation/base/route/Router.kt 0.00% <0.00%> (ø)

@VysotskiVadim VysotskiVadim merged commit 82a5531 into release-v2.17 Nov 3, 2023
4 of 7 checks passed
@VysotskiVadim VysotskiVadim deleted the NAVAND-1546-cp branch November 3, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants