NAVAND-547 route refresh for new annotations #7582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChangelogFeatures
Bug fixes and improvements
Known issues
|
VysotskiVadim
added
the
needs backporting
Codecov Report
@@ Coverage Diff @@
## main #7582 +/- ##
=========================================
Coverage 74.15% 74.15%
- Complexity 6154 6156 +2
=========================================
Files 830 830
Lines 32936 32952 +16
Branches 3933 3935 +2
=========================================
+ Hits 24423 24437 +14
Misses 6978 6978
- Partials 1535 1537 +2
|
dzinad
reviewed
Oct 26, 2023
| @@ -48,6 +48,16 @@ internal object AnnotationsRefresher { | |||
| newAnnotation, | |||
| startingLegGeometryIndex, | |||
| ) { maxspeed() } | |||
| val freeFlowSpeed = mergeAnnotationProperty( | |||
There was a problem hiding this comment.
Some changes are also required in DirectionsRouteDiffProvider.
| } | ||
| newAlternatives.forEach { | ||
| assertEquals( | ||
| "some info was lost during NN -> Nav SDK transition", |
There was a problem hiding this comment.
it means that info from response doesn't match the info we get from NN
There was a problem hiding this comment.
What does it have to do with the new annotation?
| @@ -219,6 +219,8 @@ class AnnotationsRefresherTest( | |||
| .distance(listOf(1.2, 3.4, 5.6, 7.8, 9.0)) | |||
| .duration(listOf(11.2, 33.4, 55.6, 77.8, 99.0)) | |||
| .speed(listOf(41.0, 42.5, 43.1, 44.6, 45.9)) | |||
| .freeflowSpeed(listOf(1, 2, 3, 4, 5)) | |||
There was a problem hiding this comment.
Are you also gonna test it in instrumentation tests? I see a lot of room for error for NN team, they already said something would be wrong after refresh.
There was a problem hiding this comment.
Which test do you suggest?
There was a problem hiding this comment.
The same, but with NN involved. :)
We already have some tests that test annotations refresh, we could just extend them.
dzinad
approved these changes
Oct 27, 2023
dzinad
pushed a commit
that referenced
this pull request
Oct 27, 2023
dzinad
pushed a commit
that referenced
this pull request
Oct 27, 2023
dzinad
pushed a commit
that referenced
this pull request
Oct 27, 2023
dzinad
pushed a commit
that referenced
this pull request
Oct 27, 2023
dzinad
pushed a commit
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Companion PR for mapbox/mapbox-java#1567