Adasis functionality #7538

DzmitryFomchyn · 2023-09-27T23:43:19Z

Description

github-actions · 2023-09-27T23:43:51Z

Changelog

Features

Added Advanced Driver Assistance Systems (ADAS) functionality as an experimental API. [#7538](https://github.com/mapbox/mapbox-navigation-android/pull/7538)
Added NavigationViewApi#recenterCamera() that allows to programatically recenter the camera position as if the recenter button was clicked. [#7713](https://github.com/mapbox/mapbox-navigation-android/pull/7713)

Bug fixes and improvements

Fixed a bug with multiple instances of cache which resulted in excessive memory consumption. [#7688](https://github.com/mapbox/mapbox-navigation-android/pull/7688)
Improved Map Matching to avoid false deviation of the location puck to a parallel street. [#7694](https://github.com/mapbox/mapbox-navigation-android/pull/7694)
Improved handling of no storage available during navigation tiles downloading. [#7694](https://github.com/mapbox/mapbox-navigation-android/pull/7694)
Improved handling of invalid config in DeviceProfile#customConfig. [#7694](https://github.com/mapbox/mapbox-navigation-android/pull/7694)
Fixed a native crash in E-Horizon implementation caused by internal race condition. [#7694](https://github.com/mapbox/mapbox-navigation-android/pull/7694)
Fixed an issue where reroute for multi-leg routes used to fail in case waypoint_names or waypoint_targets parameters were specified without an explicit waypoint_indices parameter. [#7709](https://github.com/mapbox/mapbox-navigation-android/pull/7709)

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

The app is now considered as the one in active navigation only when an active route is set to MapboxNavigation. Previously it was always considered active. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)
When Android Auto host tells the app to stop active navigation because another app starts navigating, now SDK will enter FreeDrive mode instead of stopping trip session completely. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)

codecov · 2023-09-28T00:02:03Z

Codecov Report

Attention: 126 lines in your changes are missing coverage. Please review.

Comparison is base (dfbc743) 74.10% compared to head (36966f2) 74.11%.

@@            Coverage Diff             @@
##               main    #7538    +/-   ##
==========================================
  Coverage     74.10%   74.11%            
- Complexity     6165     6252    +87     
==========================================
  Files           835      852    +17     
  Lines         33175    33672   +497     
  Branches       3957     4011    +54     
==========================================
+ Hits          24584    24955   +371     
- Misses         7055     7167   +112     
- Partials       1536     1550    +14

Files	Coverage Δ
...ava/com/mapbox/navigation/core/MapboxNavigation.kt	`70.31% <100.00%> (+0.45%)`	⬆️
.../navigation/core/adas/AdasisMessageBinaryFormat.kt	`100.00% <100.00%> (ø)`
...gation/navigator/internal/MapboxNativeNavigator.kt	`0.00% <ø> (ø)`
...avigation/core/NavigationSdkInformationProvider.kt	`0.00% <0.00%> (ø)`
...navigation/core/adas/AdasisConfigMessageOptions.kt	`96.77% <96.77%> (ø)`
...ox/navigation/core/adas/AdasisConfigPathOptions.kt	`98.03% <98.03%> (ø)`
...on/core/adas/AdasisConfigProfileLongTypeOptions.kt	`97.50% <97.50%> (ø)`
...n/core/adas/AdasisConfigProfileShortTypeOptions.kt	`98.30% <98.30%> (ø)`
...x/navigation/core/adas/AdasisProfileLongOptions.kt	`96.55% <96.55%> (ø)`
.../navigation/core/adas/AdasisProfileShortOptions.kt	`96.55% <96.55%> (ø)`
... and 11 more

libnavigation-core/src/main/java/com/mapbox/navigation/core/sensor/SensorData.kt

libnavigation-core/src/main/java/com/mapbox/navigation/core/adasis/ADASISv2Message.kt

libnavigation-core/src/main/java/com/mapbox/navigation/core/adasis/AdasisConfig.kt

libnavigation-core/src/main/java/com/mapbox/navigation/core/adasis/AdasisConfigCycleTimes.kt

libnavigation-core/src/main/java/com/mapbox/navigation/core/adasis/Segment.kt

libnavigation-core/src/main/java/com/mapbox/navigation/core/adasis/ProfileShort.kt

...n-core/src/main/java/com/mapbox/navigation/core/adasis/AdasisConfigProfileLongTypeOptions.kt

...-core/src/main/java/com/mapbox/navigation/core/adasis/AdasisConfigProfileShortTypeOptions.kt

libnavigation-core/src/main/java/com/mapbox/navigation/core/adasis/ProfileLong.kt

examples/src/main/java/com/mapbox/navigation/examples/core/MapboxNavigationActivity.kt

dzinad · 2023-09-28T13:39:20Z

Approved for snapshot, but before merging we still have some follow-up to do.

libnavigation-core/src/main/java/com/mapbox/navigation/core/adasis/SpeedLimitInfo.kt

libnavigation-core/src/main/java/com/mapbox/navigation/core/adasis/SpeedLimitRestriction.kt

gradle/artifact-settings.gradle

DzmitryFomchyn · 2024-01-16T19:03:02Z

Changelog since 2.19.0-preview.1-SNAPSHOT:

Package com.mapbox.navigation.core.adasis has been renamed to com.mapbox.navigation.core.adas
AdasisConfig, AdasisConfigDataSending, AdasisConfigMessageOptions, AdasisConfigPathOptions, AdasisConfigProfileLongTypeOptions, AdasisConfigProfileShortTypeOptions, ProfileLong, ProfileShort, Segment, Stub constructors are private now. Use corresponding builder classes for object instantiation.
Now AdasisConfig.Builder requires dataSendingConfig property via constructor
ADASISv2MessageCallback has been renamed to AdasisV2MessageObserver
ProfileLong has been renamed to AdasisProfileLongOptions
ProfileShort has been renamed to AdasisProfileShortOptions
Segment has been renamed to AdasisSegmentOptions
Stub has been renamed to AdasisStubOptions
AdasisConfigDataSending has been renamed to AdasisDataSendingConfig
EdgeAdasAttributes has been renamed to AdasEdgeAttributes
SpeedLimitInfo has been renamed to AdasSpeedLimitInfo
SpeedLimitRestriction has been renamed to AdasSpeedLimitRestriction
ValueOnEdge has been renamed to AdasValueOnEdge
AdasisSpeedLimitInfo.Type has been renamed to AdasSpeedLimitInfo.SpeedLimitType. Internal subclasses have been replaced by Int values and grouped into @IntDef
Internal subclasses of AdasSpeedLimitRestriction.VehicleType has been replaced by Int values and grouped into @IntDef
SensorData.Weather.Condition has been renamed to SensorData.Weather.ConditionType. Internal subclasses have been replaced by Int values and grouped into @IntDef
AdasSpeedLimitRestriction.weather has been renamed to weatherConditionTypes

0xDAD

Only these put in red frame are Adasis related

The rest is just Adas

examples/src/main/java/com/mapbox/navigation/examples/core/AdasisActivity.kt

gradle/artifact-settings.gradle

build.gradle

gradle/dependencies.gradle

dzinad · 2024-01-23T09:39:57Z

libnavigation-core/src/main/java/com/mapbox/navigation/core/MapboxNavigation.kt

+     * @param callback Message callback
+     */
+    @ExperimentalPreviewMapboxNavigationAPI
+    fun setAdasisMessageCallback(adasisConfig: AdasisConfig, callback: AdasisV2MessageCallback) {


It's not a one-shot callback, right? If that's true, we call things like this observer, not callback.
Also maybe to register/unregister, as for all other observers we have. We also allow to unregister one specific observer.

Good catch, we definately shold rename it to observer.

Also maybe to register/unregister, as for all other observers we have. We also allow to unregister one specific observer.

We can't do as we did with other observers because NN requires AdasisConfig and if we registered an observer with config1 we won't be able to register new observer with config2.

@0xDAD can we do anything with this? Can you think of use cases where customers might need to set multiple observers with different configs?

We do not support multiple callbacks for adasis (and probably don't have to). ADASIS generation is enabled once user sets callback with corresponding config. What if end up with methods like startAdasisEhp(config, callback) and stopAdasisEhp()?

We already provide something like that. Ok, let's leave it as is for now.

libnavigation-core/src/main/java/com/mapbox/navigation/core/adasis/AdasValueOnEdge.kt

dzinad · 2024-01-23T09:47:03Z

...n-core/src/main/java/com/mapbox/navigation/core/adasis/AdasisConfigProfileLongTypeOptions.kt

+ */
+@ExperimentalPreviewMapboxNavigationAPI
+class AdasisConfigProfileLongTypeOptions private constructor(
+    val lat: Boolean,


Just curious, would anyone actually need latitude without longitude or vice versa?

these are different profiles so from adasis configuration perspective they are separate options

dzinad · 2024-01-23T09:52:13Z

libnavigation-core/src/main/java/com/mapbox/navigation/core/adasis/AdasisV2MessageCallback.kt

+     * @param messageBuffer Message buffer in format specified via [AdasisDataSendingConfig.messageBinaryFormat]
+     * @param context Additional context with metadata related to the current messages package
+     */
+    fun onMessage(messageBuffer: List<Byte>, context: AdasisMessageContext)


Do we expose any deserialization tools?

No. If we're speaking about flat buffer format, deserialisation happens with 3rd party SDK and we probably shouldn't include it to our SDK. We agreed with NN that we can share deserialisation tools with customers who need it.

In case of need, we'll be able to add this functionality in future without breaking changes.

dzinad · 2024-01-23T09:55:39Z

libnavigation-core/src/main/java/com/mapbox/navigation/core/sensor/SensorData.kt

+    }
+
+    private fun Lane.toValue(): Value {
+        val str = "{\"currentLaneIndex\": $currentLaneIndex, \"laneCount\": $laneCount}"


Is this expected that lane value is a json? Do we have some agreement on this? Value can also contain map.

Great point, thanks for noticing!

@0xDAD could you please take a look? Any guarantee that this format won't be changed?

currently we expect json like that

{"currentLaneIndex": 1, "laneCount": 3}

docs say:

Lane sensor:

value is an object with the following fields: {"currentLaneIndex": 1, "laneCount": 3}

For right-hand traffic 1 is the very right lane and so on

currentLaneIndex == 0 means that lane information is not available

It may change or it may become deprecated. Depends on how NIO uses it. I'd leave that in the form of arbitrary json object just to make it as flexible as possible but it's up to you do decide

@0xDAD On platform side we accept object, not json and we convert object to json when ween to pass it from platform to C++ side.

There might be issues if you change expected json format and don't notify us, so this solution doesn't look like reliable. Makes sense to consider changing it on NN side.

Segment, Stub, AdasisConfigDataSending types

…ueOnEdge

DzmitryFomchyn added the skip changelog Should not be added into version changelog. label Sep 27, 2023

DzmitryFomchyn force-pushed the df-adasis-preview branch from cb90434 to 4efd4f5 Compare September 28, 2023 07:55

dzinad reviewed Sep 28, 2023

View reviewed changes

libnavigation-core/src/main/java/com/mapbox/navigation/core/sensor/SensorData.kt Outdated Show resolved Hide resolved

libnavigation-core/src/main/java/com/mapbox/navigation/core/sensor/SensorData.kt Outdated Show resolved Hide resolved

DzmitryFomchyn force-pushed the df-adasis-preview branch from d3819b0 to cb8e205 Compare September 28, 2023 10:27

dzinad reviewed Sep 28, 2023

View reviewed changes

dzinad approved these changes Sep 28, 2023

View reviewed changes

examples/src/main/java/com/mapbox/navigation/examples/core/MapboxNavigationActivity.kt Outdated Show resolved Hide resolved

examples/src/main/java/com/mapbox/navigation/examples/core/MapboxNavigationActivity.kt Outdated Show resolved Hide resolved

dzinad force-pushed the df-adasis-preview branch from 59f2311 to 092542c Compare October 19, 2023 10:03

dzinad reviewed Oct 26, 2023

View reviewed changes

DzmitryFomchyn commented Dec 1, 2023

View reviewed changes

gradle/artifact-settings.gradle Outdated Show resolved Hide resolved

DzmitryFomchyn force-pushed the df-adasis-preview branch from 5a06d28 to 028824d Compare December 20, 2023 16:10

dzinad force-pushed the df-adasis-preview branch from ced9fd7 to 93ad42d Compare December 21, 2023 16:07

DzmitryFomchyn force-pushed the df-adasis-preview branch from 66bf4fc to 2bc2141 Compare January 10, 2024 01:04

dzinad force-pushed the df-adasis-preview branch 2 times, most recently from 8a13250 to b71478d Compare January 12, 2024 19:16

DzmitryFomchyn force-pushed the df-adasis-preview branch 3 times, most recently from d22dfce to 08b55d3 Compare January 16, 2024 18:56

DzmitryFomchyn requested review from 0xDAD and dzinad January 16, 2024 18:56

DzmitryFomchyn marked this pull request as ready for review January 16, 2024 18:57

DzmitryFomchyn requested a review from a team as a code owner January 16, 2024 18:57

DzmitryFomchyn changed the title ~~Adasis preview~~ Adasis functionality Jan 16, 2024

DzmitryFomchyn force-pushed the df-adasis-preview branch from 08b55d3 to e33abae Compare January 18, 2024 18:47

0xDAD suggested changes Jan 22, 2024

View reviewed changes

DzmitryFomchyn requested a review from 0xDAD January 22, 2024 23:46

dzinad reviewed Jan 23, 2024

View reviewed changes

DzmitryFomchyn added 10 commits January 23, 2024 15:51

ADAS functionality

f9eab74

[test] New NN

d17e93a

Private constructor and builders for public types

f9f2b33

Rename ProfileLong, ProfileShort, ProfileShortOptions,

376974d

Segment, Stub, AdasisConfigDataSending types

Rename EdgeAdasAttributes, SpeedLimitInfo, SpeedLimitRestriction, Val…

a205101

…ueOnEdge

IntDef for AdasisSpeedLimitInfo type

9ddd68d

IntDef for AdasisSpeedLimitRestriction.VehicleType

b3c3e9f

IntDef for SensorData.Weather.Condition

7773dba

Adasis example activity

57a91fc

Add tests

ad77e78

DzmitryFomchyn force-pushed the df-adasis-preview branch from 36fd4a4 to 61120d0 Compare January 23, 2024 14:52

0xDAD approved these changes Jan 23, 2024

View reviewed changes

Migrate to NN 201.0.0

36966f2

DzmitryFomchyn force-pushed the df-adasis-preview branch from 61120d0 to 36966f2 Compare January 23, 2024 15:21

DzmitryFomchyn merged commit ff95d8c into main Jan 23, 2024
38 of 43 checks passed

DzmitryFomchyn deleted the df-adasis-preview branch January 23, 2024 16:46

mapbox-github-ci-issues-2 bot mentioned this pull request Jan 23, 2024

PR #7538 merged without successful status checks (mapbox-navigation-android) #7723

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adasis functionality #7538

Adasis functionality #7538

DzmitryFomchyn commented Sep 27, 2023

github-actions bot commented Sep 27, 2023 •

edited

Loading

Features

Bug fixes and improvements

Known issues ⚠️

Other changes

Features

Bug fixes and improvements

codecov bot commented Sep 28, 2023 •

edited

Loading

dzinad commented Sep 28, 2023

DzmitryFomchyn commented Jan 16, 2024 •

edited

Loading

0xDAD left a comment •

edited

Loading

dzinad Jan 23, 2024

DzmitryFomchyn Jan 23, 2024

0xDAD Jan 23, 2024

DzmitryFomchyn Jan 23, 2024

dzinad Jan 23, 2024

0xDAD Jan 23, 2024

dzinad Jan 23, 2024

DzmitryFomchyn Jan 23, 2024

dzinad Jan 23, 2024

DzmitryFomchyn Jan 23, 2024

0xDAD Jan 23, 2024

DzmitryFomchyn Jan 23, 2024

Adasis functionality #7538

Adasis functionality #7538

Conversation

DzmitryFomchyn commented Sep 27, 2023

Description

github-actions bot commented Sep 27, 2023 • edited Loading

Features

Bug fixes and improvements

Known issues ⚠️

Other changes

Features

Bug fixes and improvements

codecov bot commented Sep 28, 2023 • edited Loading

Codecov Report

dzinad commented Sep 28, 2023

DzmitryFomchyn commented Jan 16, 2024 • edited Loading

0xDAD left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 27, 2023 •

edited

Loading

codecov bot commented Sep 28, 2023 •

edited

Loading

DzmitryFomchyn commented Jan 16, 2024 •

edited

Loading

0xDAD left a comment •

edited

Loading