Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add disableContinuousAlternatives test #7481

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dzinad
Copy link
Contributor

@dzinad dzinad commented Aug 24, 2023

No description provided.

@dzinad dzinad requested a review from a team as a code owner August 24, 2023 10:41
@github-actions
Copy link

Changelog

Features

Bug fixes and improvements

  • Fixed an issue when Nav SDK removed primary route due to false positive detection of deviation to an alternative route. Now previous primary route is removed via continuous alternatives mechanism which has a higher certainty threshold to remove passed alternative. [#7470](https://github.com/mapbox/mapbox-navigation-android/pull/7470)
  • Fixed warnings produced by MapboxMap when predictive cache controller interacted with an invalid map. [#7466](https://github.com/mapbox/mapbox-navigation-android/pull/7466)

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

  • The app is now considered as the one in active navigation only when an active route is set to MapboxNavigation. Previously it was always considered active. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)
  • When Android Auto host tells the app to stop active navigation because another app starts navigating, now SDK will enter FreeDrive mode instead of stopping trip session completely. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)

mockLocationReplayerRule.playRoute(routes.first().directionsRoute)

mapboxNavigation.flowOnFinalDestinationArrival().first()
assertEquals(0, alternativeUpdates)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we expect 1 update which removes passed alternative?

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #7481 (c801f60) into main (97ed9a5) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #7481   +/-   ##
=========================================
  Coverage     74.11%   74.11%           
  Complexity     6141     6141           
=========================================
  Files           828      828           
  Lines         32833    32833           
  Branches       3912     3912           
=========================================
  Hits          24335    24335           
  Misses         6964     6964           
  Partials       1534     1534           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants