Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAVAND-1311: introduce violated section in route line #7134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

NAVAND-1311: introduce violated section in route line #7134

wants to merge 2 commits into from

Conversation

dzinad
Copy link
Contributor

@dzinad dzinad commented Apr 20, 2023 •
edited
Loading

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 20, 2023 •
edited
Loading

Changelog

Features

  • Added MapboxRouteLineOptions#displayViolatedSections option and RouteLineColorResources#violatedSectionColor, RouteLineColorResources#alternativeRouteViolatedSectionColor, RouteLineResources#violatedSectionDashArray, RouteLineResources#violatedSectionOpacity, RouteLineResources#violatedSectionLineWidth to modify the route line style of violated sections. The section is considered violated when some of the restricting request parameters (e. g. maxHeight, maxWidth, exclude, etc.) were violated. [#dd](https://github.com/mapbox/mapbox-navigation-android/pull/dd)

Bug fixes and improvements

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

@dzinad dzinad force-pushed the NAVAND-1311-dd branch from 35676fe to cf9221e Compare May 2, 2023 11:02
@dzinad dzinad changed the title tmp NAVAND-1311: introduce violated section in route line May 2, 2023
@dzinad dzinad force-pushed the NAVAND-1311-dd branch from cf9221e to ecab7e3 Compare May 2, 2023 11:07
@dzinad dzinad force-pushed the NAVAND-1311-dd branch from ecab7e3 to d40b998 Compare May 2, 2023 11:15
@dzinad dzinad marked this pull request as ready for review May 2, 2023 11:16
@dzinad dzinad requested review from LukasPaczos and cafesilencio May 2, 2023 11:16
@cafesilencio
Copy link
Contributor

How is this different from route restrictions? Is there any context available regarding the feature requirements for this?

@dzinad
Copy link
Contributor Author

dzinad commented May 3, 2023

How is this different from route restrictions? Is there any context available regarding the feature requirements for this?

It's based on different data.
More about route notifications with design mockups: https://docs.google.com/document/d/1VPyj31D5SWCKSMATqXKt6OFCJnfB9gQFYFGQt-oB2SA/edit#heading=h.1s8fyfwsyhjo

cafesilencio
cafesilencio reviewed May 3, 2023
View reviewed changes
gradle/dependencies.gradle
@@ -19,7 +19,7 @@ ext {

version = [
mapboxMapSdk : '10.13.0-rc.1',
mapboxSdkServices : '6.11.0',
mapboxSdkServices : '6.12.0-dzina',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure this doesn't get merged.

@cafesilencio
Copy link
Contributor

I'm not able to run the QA app. from this branch. I'm guessing it's because of mapboxSdkServices : '6.12.0-dzina'. Is there another way to test this feature?

cafesilencio
cafesilencio reviewed May 3, 2023
View reviewed changes
...maps/src/main/java/com/mapbox/navigation/ui/maps/internal/route/line/MapboxRouteLineUtils.kt
val startRouteLineDistance = legDistances?.getOrNull(startIndex)
val endRouteLineDistance = legDistances?.getOrNull(endIndex)
if (startRouteLineDistance != null && endRouteLineDistance != null) {
val startOffset = 1.0 - startRouteLineDistance.distanceRemaining / routeDistance!!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If granularDistances above is nullable doesn't that also mean granularDistances?.completeDistance can be null? Here you're assuming it won't be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then startRouteLineDistance would be null and we wouldn't have entered this branch.

@dzinad
Copy link
Contributor Author

dzinad commented May 4, 2023

I'm not able to run the QA app. from this branch. I'm guessing it's because of mapboxSdkServices : '6.12.0-dzina'. Is there another way to test this feature?

Unfortunately I can't merge mapbox-java PR and release it until it's all ready on server-side.
You can assemble mapbox-java from here: mapbox/mapbox-java#1542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cafesilencio cafesilencio cafesilencio left review comments

@LukasPaczos LukasPaczos Awaiting requested review from LukasPaczos

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzinad @cafesilencio