Make ReplayRouteSession and TripSessionStarter handle route changes #6913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChangelogFeatures
Bug fixes and improvements
Known issues
|
kmadsen
force-pushed
the
km-improve-replay-route-session
branch
from
cc70912 to
959b5ea
Compare
kmadsen
force-pushed
the
km-improve-replay-route-session
branch
from
7fb60f8 to
942ea75
Compare
Zayankovsky
reviewed
Feb 3, 2023
| implementation("com.mapbox.navigation:ui-dropin:2.10.0-rc.1") | ||
| implementation("com.mapbox.search:mapbox-search-android:1.0.0-beta.42") | ||
| implementation("com.mapbox.navigation:ui-dropin:2.10.0") | ||
| implementation("com.mapbox.search:mapbox-search-android:1.0.0-beta.43") |
There was a problem hiding this comment.
Android Auto uses 1.0.0-beta.44.
| @@ -72,8 +72,8 @@ dependencies { | |||
| // This example is used for development so it may depend on unstable versions. | |||
| // Examples based on final versions can be found in the examples repository. | |||
| // https://github.com/mapbox/mapbox-navigation-android-examples | |||
| implementation("com.mapbox.navigation:ui-dropin:2.10.0-rc.1") | |||
| implementation("com.mapbox.search:mapbox-search-android:1.0.0-beta.42") | |||
| implementation("com.mapbox.navigation:ui-dropin:2.10.0") | |||
There was a problem hiding this comment.
You need to use 2.11.0 beta, otherwise it doesn't compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Status: opening as a draft cause i just made it work and need to update the tests
There are a couple experiences we have found that need improvement with the
ReplayRouteSession.ReplayRouteSessionand callingresetTripSessionThis pull request is addressing
1. I haven't tested2much yet. But it works with Android Auto so I'm adding a video that demonstrates an improvement to the new junction view example. Now you can select routes and have the replayer reset to that location.Screenshots or Gifs
better-replay-route-720p.mov