Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #228 Validation and Timings updated for listing a Movie #243

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

Akshithsaai
Copy link
Contributor

Fixes: #228

Implemented Required validation for listing movie and also added default timing values to movie timings.

ScreenShots:

image

@maniyaom Please check it out.

Copy link

vercel bot commented Oct 9, 2024

@Akshithsaai is attempting to deploy a commit to the ommaniya70's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

@Akshithsaai

Thank you for your Pull Request!

We truly appreciate your contribution! 🙌
We will review the changes and provide feedback or merge the PR soon. 🔍
Please stay tuned for updates! 🔔

🌟 Thank you for your efforts in improving the project! 🙏

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
movie-ticket-booking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 4:23am

@Akshithsaai
Copy link
Contributor Author

@maniyaom Please check the validation and suggest the changes...

@maniyaom
Copy link
Owner

@Akshithsaai Sorry for the delayed response, I’ve been tied up the past two days.

@maniyaom
Copy link
Owner

@Akshithsaai If the user does not add a poster, they are still able to add the movie.

@maniyaom maniyaom self-requested a review October 12, 2024 14:59
@Akshithsaai
Copy link
Contributor Author

@maniyaom I will add the validation and update the PR by today EOD.

@Akshithsaai
Copy link
Contributor Author

@maniyaom I have added validation , Please check.

image
image

Copy link
Contributor

@Akshithsaai

🎉 Great news! Your pull request has been successfully merged. We appreciate your contribution!

🙌 Please feel free to check out the other issues on our website and see if there’s anything else you’d like to contribute with. 💻

@github-actions github-actions bot merged commit d3ba24a into maniyaom:master Oct 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Form Validation and Adding a default time for Listing movies
2 participants