-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binja database support #2501
Binja database support #2501
Conversation
I think you should take a trivial file, like PMA 01-01.dll, and use that. The test only needs to show that the db file can be analyzed, not that all the features are extracted consistently (which we can assume will be the case, I think). |
return False | ||
return None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
Pending tests |
61b4453
to
39810da
Compare
I added a test for for it, please have a look! |
Oh well apparently I only added the database file and the feature list, but forgot to make it actually run during the test. I will push a fix shortly |
39810da
to
b9a9eb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
Just so that you know this branch is failing the (newly added) unit test (sorry I wrote the code without running the unit test, I thought it is way to easy to bother with testing at all) All new binja db tests are failing because it cannot properly get a binary view, I am yet to see what is happening. It does work perfectly fine when I analyze a standalone file outside of the unit test infra |
b9a9eb1
to
28fcd10
Compare
@williballenthin oh well it is just a simple typo in the file path. I have fixed it and this should be ready for merge |
Thank you! |
@mr-tz thx for merging this! However, since I also introduced a submodule change on the test files, now the capa repo points to this commit https://github.com/mandiant/capa-testfiles/tree/b40457c616604ee65f44e1ae8597cfeec7da0f70 which is not on top of the master branch of the capa-testfiles repo. I believe you should cherry-pick this commit on capa-testfiles |
Good catch, done. Thank you! |
This PR adds support for loading and analyzing a binja database: #2496
There are two things I wish to mention:
test_binja_features.py
?Checklist