fixes error with unpacking packages #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes first layer of package did have different normalization that item.name and script couldn't open it also normalize content of archive after unpacking, same issue as in pull request mandarons#144
tymmej
changed the title
|
@tymmej Can you please provide a sample package file which needs to be normalized? I want to add it to test data and write a test with it. |
|
Inside archive test.tar.gz is package "Fotoksiążka Wzór.xmcf" which causes problem. If you want minimal example I believe any package with non-ASCII characters in filename causes problem - https://gist.github.com/JamesChevalier/8448512?permalink_comment_id=2846892 Some non-ASCII characters to test: ĄąÓóŻż (polish letters) |
Closed
mandarons
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes first layer of package did have different normalization that item.name and script couldn't open it
also normalize content of archive after unpacking, same issue as in pull request #144