Keep spoiler history instead of force-pushing #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaliaarchi
force-pushed
the
spoiler-action
branch
from
4eb59da to
198a6d7
Compare
mame
reviewed
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that it is difficult to reproduce old versions of quine-relay, even with the Dockerfile, because of unsupported Ubuntu versions and changing package versions. Even when I get it to work, it takes a very long time to run for all commits. The spoiler branch already has these build artifacts, so why doesn't it work? Well, it's force-pushed by GitHub Actions every time a change is pushed to master, so there is only the latest version.
With this PR, starting from now, updates to spoiler will simply push, so that the changes to spoiler can be tracked.
Since it was hard-coded to push to your repo, I made it work when run from a fork. Additionally, it will now have a more descriptive commit message and use the author information from the triggering commit and GitHub Actions as the committer.
You can see what this change looks like in the spoiler branch of my fork.