New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement v2 for Lockstake #16

Merged

sunbreak1211 merged 36 commits into master from v2

Oct 23, 2024

Contributor

sunbreak1211 commented Jan 15, 2024

No description provided.

sunbreak1211 added 4 commits

October 25, 2023 16:47


          Remove ds-test

df6f710


          forge install: dss-test

0224caf


          Changes for V2

0bf1da5


          Remove comments

782e613

DaiFoundation-DevOps commented Jan 15, 2024 •

edited

Loading

All committers have signed the CLA.

oldchili reviewed

View reviewed changes

test/VoteDelegateFactory.t.sol Outdated Show resolved Hide resolved

oldchili reviewed

View reviewed changes

src/VoteDelegateFactory.sol Outdated Show resolved Hide resolved

telome reviewed

View reviewed changes

test/VoteDelegate.t.sol Outdated Show resolved Hide resolved

telome reviewed

View reviewed changes

test/VoteDelegateFactory.t.sol Outdated Show resolved Hide resolved

telome reviewed

View reviewed changes

src/VoteDelegateFactory.sol Outdated Show resolved Hide resolved

telome reviewed

View reviewed changes

src/VoteDelegate.sol Outdated Show resolved Hide resolved

telome reviewed

View reviewed changes

test/VoteDelegate.t.sol Show resolved Hide resolved

telome reviewed

View reviewed changes

test/VoteDelegate.t.sol Outdated Show resolved Hide resolved

telome reviewed

View reviewed changes

test/VoteDelegate.t.sol Show resolved Hide resolved

sunbreak1211 and others added 4 commits

February 27, 2024 17:28


          Minor changes

a51f390

Co-authored-by: oldchili <[email protected]>
Co-authored-by: telome <[email protected]>


          Fix copyright year

197106f


          Add testConstructor

ba3c300


          Test Lock and Free events

5f8c76f

sunbreak1211 marked this pull request as ready for review

February 27, 2024 21:21

sunbreak1211 added 4 commits

February 27, 2024 18:30


          Change comment

3129ccb


          Minor changes to lock and free

c98ed1c


          Minor changes to tests

8fa3418


          More minor changes for tests

39d9af1

oldchili reviewed

View reviewed changes

src/VoteDelegateFactory.sol Outdated Show resolved Hide resolved

oldchili reviewed

View reviewed changes

src/VoteDelegate.sol Show resolved Hide resolved

oldchili reviewed

View reviewed changes

src/VoteDelegate.sol Show resolved Hide resolved

telome reviewed

View reviewed changes

src/VoteDelegateFactory.sol Outdated Show resolved Hide resolved

sunbreak1211 added 3 commits

February 28, 2024 10:19


          Add CreateVoteDelegate event back

2aafc61


          Remove return value of interface

2f53049


          Remove unused functions from interface

4bd338a

telome reviewed

View reviewed changes

test/VoteDelegate.t.sol Outdated Show resolved Hide resolved

sunbreak1211 commented

View reviewed changes

test/VoteDelegate.t.sol Outdated Show resolved Hide resolved


          Minor changes to tests

350f279

Co-authored-by: telome <[email protected]>

telome approved these changes

View reviewed changes

Contributor

telome left a comment

LGTM

oldchili reviewed

View reviewed changes

test/VoteDelegate.t.sol Show resolved Hide resolved


          Add checks back to test

bcef5e6

oldchili approved these changes

View reviewed changes

Contributor

oldchili left a comment

LGTM

telome approved these changes

View reviewed changes

sunbreak1211 added 2 commits

February 29, 2024 11:30


          Add delegates getter to the factory to keep compatibility with prev v…

b59e5be

…ersion


          Change comment position

edf24ce

telome approved these changes

View reviewed changes

oldchili approved these changes

View reviewed changes

Contributor

oldchili left a comment

LGTM

oldchili and others added 5 commits

April 12, 2024 09:40


          Reserve free window (aka hatch), then enforce cool-down (#18)

c01dda0

* Reserve free window (aka hatch), then enforce cooldown

* Change hatch/cool-dwon to 5/5

* Do not prank when calling proxy.reserveHatch() in test

* Add ReserveHatch event

* Change HATCH_COOLDOWN to 20

---------

Co-authored-by: sunbreak1211 <[email protected]>


          Add uncommited change to VoteDelegate.t.sol

d2db093


          Use solc 0.8.21 + upgrade dss-tests and fix warnings due to it (#19)

9519c82


          Add CS audit

d6e563f


          Post Cantina Audit Minor Changes (#20)

63700ad

* Use >= in reserveHatch

* Remove hashing in salt calculation

* Remove unneeded warps

oldchili approved these changes

View reviewed changes

Contributor

oldchili left a comment

LGTM

oldchili and others added 7 commits

July 3, 2024 16:35


          Add Cantina Report (#21)


          Update CS Report (#22)

67a7d64


          Use regular create in VoteDelegateFactory (#23)

01e7b57

* Use regular create in VoteDelegateFactory

* Use vm.coputeCreateAddress instead of snapshot

Co-authored-by: sunbreak1211 <[email protected]>

---------

Co-authored-by: sunbreak1211 <[email protected]>


          Update CS audit report (#24)

64dfa96


          Add Cantina updates audit report (#25)

3fba35c


          Add Sherlock Report (#26)

efc415c


          Add Certora specs + configure CI for tests and Certora (#27)

2a585d7

* Add Certora specs + configure CI for tests and Certora

* Fix spacing

* Workaround for fixing voteYays_revert

* Minor change + comment

* Use no optimization for mocks and aux

Contributor Author

sunbreak1211 commented Oct 21, 2024

@telome @oldchili please give final approval and I'll get this merged. It will be used regular merging type to preserve audited commits.


          Certora: Minor change

c8ab9cb

oldchili approved these changes

View reviewed changes

telome approved these changes

View reviewed changes

sunbreak1211 merged commit 25b63b0 into master

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet