Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unhide migration banner for delegators & only count v2 renewals for delegator migration #949

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tyler17
Copy link
Collaborator

@tyler17 tyler17 commented Oct 24, 2024

No description provided.

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 0:37am

Copy link

what-the-diff bot commented Oct 24, 2024

PR Summary

  • Update in Data Design
    Modified a function named fetchDelegatedTo.ts to update some naming and checks for consistency and better readability. This provides a more logical flow for future developers or contributors when maintaining or updating our services.

  • Type Definition Update
    The changes in delegate.d.ts are procedural following a change in another file. Essentially, what's happened here is that we've confirmed a type (a way of classifying data) has been updated to match changes made elsewhere in the codebase.

  • Visual Output Enhancement
    There have been some changes in MigrationBanner.tsx, this file controls how a specific element - the migration banner - is shown to users. The logic for its display has been updated to improve the user experience and provide timely and contextual information.

  • Codebase Clean-up
    Beneficial modifications have been made in useMigrationStatus.tsx where unused variables related to expired and expiring contracts were removed. This clean-up makes the code more maintainable and comprehensible by keeping only necessary components intact.

  • Business Logic Improvement
    In the same file useMigrationStatus.tsx, logic has been changed to use the new property isRenewedToV2 for verifying if a person is delegating to a specific version of a contract. This allows a smoother working process by having logic that's consistent with the rest of the application. The customers should benefit from this through faster and more reliable app functionalities.

@tyler17 tyler17 changed the title unhide migration banner for delegators unhide migration banner for delegators & only count v2 renewals for delegator migration Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant