[WEB-3039] fix: dashboard completed issues count

[NarayanBavisetti]

Description

fixed the count of dashboard completed issues

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

WEB-3039

Summary by CodeRabbit

• Bug Fixes
  • Improved issue filtering logic in dashboard and workspace user profile stats
  • Refined issue assignment tracking to exclude deleted assignments
  • Enhanced accuracy of issue-related statistics by filtering out inactive assignments

[makeplane]

Pull Request Linked with Plane Issues

Comment Automatically Generated by Plane

[coderabbitai]

Walkthrough

The pull request introduces modifications to issue filtering logic in two backend files: dashboard/base.py and workspace/user.py. The primary change involves updating how completed issues are counted by adding a new condition that checks for non-deleted issue assignments. This ensures that only active issue assignments are considered when calculating various dashboard and user profile statistics, potentially improving the accuracy of issue tracking and reporting.

Changes

File	Change Summary
apiserver/plane/app/views/dashboard/base.py	Modified completed_issues_count calculation with updated filtering condition for issue assignments
apiserver/plane/app/views/workspace/user.py	Updated WorkspaceUserProfileStatsEndpoint filtering logic for multiple issue-related queries, ensuring only non-deleted issue assignments are counted

Possibly related PRs

• [WEB-3039] fix: assignee count in dashboard #6418: Similar modification of dashboard function filtering logic for assigned issues

Suggested labels

🐛bug, ⚙️backend

Suggested reviewers

• pablohashescobar
• SatishGandham

Poem

🐰 Hopping through code with glee,
Filtering issues, setting data free!
No more ghosts of assignments past,
Clean queries that are built to last!
A rabbit's touch of backend art 🔍

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62dd808 and 0fbb92c.

📒 Files selected for processing (2)

• apiserver/plane/app/views/dashboard/base.py (1 hunks)
• apiserver/plane/app/views/workspace/user.py (5 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: lint-apiserver
• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (2)

apiserver/plane/app/views/workspace/user.py (1)

378-381: LGTM! Consistent implementation of filtering deleted assignments.

The changes correctly ensure that only active (non-deleted) issue assignments are considered in the statistics by adding the issue_assignee__deleted_at__isnull=True condition. This fix is consistently applied across all queries.

Let's verify the impact of these changes:

Also applies to: 397-400, 435-438, 450-453, 464-467

✅ Verification successful

✓ Verified: Soft deletion of assignments is properly implemented

The codebase shows consistent and correct handling of deleted assignments:

• Database-level constraints ensure data integrity
• The deleted_at check is uniformly applied across all relevant queries
• The implementation follows the established pattern used in related features

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the presence of deleted assignments that were previously being counted.
# This will help understand the scale of the fix.

# Test: Search for deleted assignments that would have been counted before this fix
rg -A 5 'issue_assignee.*deleted_at.*is not null'

Length of output: 51

---

Script:

#!/bin/bash
# Find the model definition for issue assignee
ast-grep --pattern 'class IssueAssignee($$$)'

# Look for related test files
fd -e py test.*assignee

# Find similar query patterns in the codebase
rg -B2 -A2 'issue_assignee.*deleted_at'

# Check for related migrations
fd -e py -p '.*migrations.*' | xargs rg 'IssueAssignee'

Length of output: 15797

apiserver/plane/app/views/dashboard/base.py (1)

136-139: LGTM! Consistent with workspace view implementation.

The changes correctly ensure that only active (non-deleted) issue assignments are counted in the dashboard overview, maintaining consistency with the workspace view implementation.

Let's verify the consistency between dashboard and workspace views:

✅ Verification successful

Verification successful: Dashboard and workspace views are consistent

The completed issues filtering logic is identical between dashboard and workspace views, both properly handling deleted assignments and maintaining consistent workspace/project context filters.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that both dashboard and workspace views use the same filtering logic.

# Test: Search for all occurrences of completed issues filtering
ast-grep --pattern $'Issue.issue_objects.filter(
  $$$
  state__group="completed"
  $$$
)'

Length of output: 5247

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.