Fix imapsync to support other ports for IMAP Server than 143 #6229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of configuring a different port for the builtin IMAP server the synchronization fails. The reason is there was a missing definition for the port of the destination machine. This will now be added if the IMAP_PORT environment is set.
|
Refs #6228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
What does this PR include?
Short Description
In case of configuring a different port for the builtin IMAP server the synchronization fails. The reason is there was a missing definition for the port of the destination machine (--port2 parameter to imapsync). This will now be added if the IMAP_PORT environment is set.
Affected Containers
Did you run tests?
Yes, for my setup.
What did you tested?
I tested if sync now works for my config with a dovecot on Port 9143. The port is now passed correctly.
What were the final results? (Awaited, got)
The sync does no longer fail.