Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] remove f2b banlist from json_api.php #6168

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

FreddleSpl0it
Copy link
Collaborator

@FreddleSpl0it FreddleSpl0it commented Nov 14, 2024

Contribution Guidelines

What does this PR include?

Short Description

Move the f2b-banlist endpoint from json_api.php to a separate PHP file to ensure the correct Content-Type (text/plain) is sent.
Resolves #6089

Admins using this feature will need to update the f2b-banlist URL after applying this update!

Affected Containers

  • PHP-FPM

Did you run tests?

What did you tested?

I checked that the new f2b-banlist link appears as /f2b-banlist?id=<ID> and that the correct Content-Type is being sent.

What were the final results? (Awaited, got)

I verified that the correct Content-Type text/plain is sent when navigating to /f2b-banlist?id=<ID>.

@FreddleSpl0it FreddleSpl0it force-pushed the fix/f2b-banlist branch 2 times, most recently from c2848b8 to 322c2a5 Compare November 14, 2024 09:39
@FreddleSpl0it FreddleSpl0it marked this pull request as ready for review November 14, 2024 09:46
@DerLinkman DerLinkman force-pushed the staging branch 2 times, most recently from aaee040 to 4d688c5 Compare November 15, 2024 15:17
@FreddleSpl0it FreddleSpl0it merged commit 922f877 into staging Nov 19, 2024
@FreddleSpl0it FreddleSpl0it deleted the fix/f2b-banlist branch December 6, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants