Expose the same protocols in autoconfig and autodiscover #6014
Conversation
Also drop dynamic config based on SRV values
| <SPA>off</SPA> | ||
| <SSL>on</SSL> | ||
| <AuthRequired>on</AuthRequired> | ||
| </Protocol> |
There was a problem hiding this comment.
This is inside the $autodiscover_config['autodiscoverType'] == 'imap' section, which I don't think makes sense. Does Outlook even support having both IMAP and POP3 in the same discovery? Which one does it pick?
| </incomingServer> | ||
|
|
||
| <?php | ||
| $records = dns_get_record('_pop3s._tcp.' . $domain, DNS_SRV); // check if POP3 is announced as "not provided" via SRV record |
There was a problem hiding this comment.
I think being able to hide POP3 was useful. In fact, I was the person who added this code seven years ago. However, I do understand that you want to deal with situations where the DNS might unreliable. So instead of unconditionally presenting both POP3S and IMAPS, perhaps we could either have a configuration switch somewhere, or, perhaps more conveniently, simply query our database and hide the protocol if it is disabled for all mailboxes (and all their app passwords) of the domain.
|
Since the 4th of July on https://community.mailcow.email/d/3803-disable-plain-ports-starttls-and-force-tls, #5944 and #5945 I have been trying to explain and fix the problem of autoconfig and autodiscover exposing different protocols, as well as the option to disable potentially less secure STARTTLS. For the fourth time, we are starting the discussion all over again, after trying to find out exactly how you want it to be implemented (long discussion in #5945), after reverting the merged previous one. I'm sorry, I don't see any way that we can address it in a way that you all agree on, other than what we all want to have as an option in the backend, but I see that in the distant future. |
|
My intention was not to decline this pull request, quite the contrary. I was merely pointing out that the change to autodiscovery.php had a logic error and the functionality removed from autoconfig.php could be added in a different way without much of a hassle. |
Contribution Guidelines
What does this PR include?
Short Description
This PR streamlines the exposure of protocols in autoconfig and autodiscover by dropping dynamic config based on SRV values for autoconfig, for more information see #5944 and #5945 .
Affected Containers
Did you run tests?
No