Fail2Ban API Banlist Error

[daygle]

Contribution guidelines

• I've read the contribution guidelines and wholeheartedly agree

I've found a bug and checked that ...

• ... I understand that not following the below instructions will result in immediate closure and/or deletion of my issue.
• ... I have understood that this bug report is dedicated for bugs, and not for support-related inquiries.
• ... I have understood that answers are voluntary and community-driven, and not commercial support.
• ... I have verified that my issue has not been already answered in the past. I also checked previous issues.

Description

api/v1/get/fail2ban/banlist/ not working.

Error - SyntaxError: JSON.parse: unexpected end of data at line 1 column 1 of the JSON data

Logs:

No logs available for this error.

Steps to reproduce:

1. Login to mailcow with your administrator account.
2. Navigate to System > Configuration > Options > Fail2ban parameters
3. Scroll down to the bottom of the page and locate https://mail.domain.net/api/v1/get/fail2ban/banlist/5297f53f-8fe2-4890-9ca0-f93753137e41
4. Copy link and paste in to browser.
5. Error - SyntaxError: JSON.parse: unexpected end of data at line 1 column 1 of the JSON data

Which branch are you using?

master

Which architecture are you using?

x86

Operating System:

Ubuntu 22.04

Server/VM specifications:

10GB

Is Apparmor, SELinux or similar active?

Yes

Virtualization technology:

Proxmox

Docker version:

Latest

docker-compose version or docker compose version:

Latest

mailcow version:

2024-08a

Reverse proxy:

Nginx

Logs of git diff:

N/A

Logs of iptables -L -vn:

N/A

Logs of ip6tables -L -vn:

N/A

Logs of iptables -L -vn -t nat:

N/A

Logs of ip6tables -L -vn -t nat:

N/A

DNS check:

N/A

[daygle]

[apio-sys]

This is usually the case when you currently have no banned IPs, hence the json is empty and returns this error in a browser. If you curl the URL, you will just get an empty response as expected if now hosts banned. Can you confirm that in your UI it says No active bans just above the URL? That will confirm it is not a bug but just expected behaviour.

[daygle]

Thanks @apio-sys - See attached screenshot, although I have one banned IP is still throws the error :(

[apio-sys]

And if you curl the URL do you get any output?

[daygle]

And if you curl the URL do you get any output?

@apio-sys Sure do.

[apio-sys]

OK so data is there then. Maybe something to do with formatting. I don't see curly brackets around the data. Have you tried different browsers to open the URL? If you go to "raw data" don't you see the same output as in curl? Sorry out of ideas otherwise.

[daygle]

Thanks @apio-sys - Yeah, tried other browsers. Raw data shows the error. I suspect all users have the same issue.

[apio-sys]

I think you are right. I'll try to confirm this as soon as I catch an IP in fail2ban, currently have none. The data is there, it's just the formatting which doesn't seem proper json.

[GeistFighter]

Hello,

I also have the same problems with version 2024-08a, and the problem occurs whether the banlist is empty or has more than 300 active bans. (Trying to retrieve the content via curl works fine)

[daygle]

@andryyy Just wondering if there was any progress on this one?

[andryyy]

Me? Did you by chance ping the wrong guy? :)

[daygle]

Oh sorry @andryyy.

[foorschtbar]

Thanks @apio-sys - See attached screenshot, although I have one banned IP is still throws the error :(

Same here. Error with one entry or without any. No change after recreating the API URL/token

[daygle]

@foorschtbar Not sure if anyone from mailcow is looking at this? Would love to see it get fixed soon so that I am able to manage blocked IP addresses via OPNsense.

[DerLinkman]

We'll take a look at this soon.

[FreddleSpl0it]

The endpoint returns a simple list not json.
I will move the endpoint to a different location, away from json_api.php.

[daygle]

Thanks team :)