feat(add-to/cart): Let it be shown for unavailable products #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailable If the button is shown in some tiles and in some not, and if the button affects the dimensions of the tile (e.g. when it's shown as a additional block in the bottom of the tile, extending its' height), it will cause some tiles to be taller than the others. This commit allows the dev to enforce the button to be shown for all products (including unavailable ones) by setting an option in xml (and styling it differently through css, when the product is unavailable).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the button is shown in some tiles and in some not, and if the button affects the dimensions of the tile (e.g. when it's shown as a additional block in the bottom of the tile, extending its' height), it will cause some tiles to be taller than the others.
An example of that can be seen on the screenshot below - unavailable products have their title not aligned with the available products:
This commit allows the dev to enforce the button to be shown for all products (including unavailable ones) by setting an option in xml (and styling it differently through css, when the product is unavailable).