Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA-3359 : Allowing null values into the Product Thumbnail GrapQL in … #4342

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

PWA-3359 : Allowing null values into the Product Thumbnail GrapQL in … #4342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a46975
PWA-3359 : Allowing null values into the Product Thumbnail GrapQL in …
del15881 Oct 9, 2024
ddba300
Prettify the code changes
del15881 Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/peregrine/lib/talons/OrderHistoryPage/orderRow.gql.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const GET_CONFIGURABLE_THUMBNAIL_SOURCE = gql`
`;

export const GET_PRODUCT_THUMBNAILS_BY_URL_KEY = gql`
query GetProductThumbnailsByURLKey($urlKeys: [String!]!) {
query GetProductThumbnailsByURLKey($urlKeys: [String]!) {
products(filter: { url_key: { in: $urlKeys } }) {
# eslint-disable-next-line @graphql-eslint/require-id-when-available
items {
Expand Down
3 changes: 3 additions & 0 deletions packages/venia-ui/lib/components/OrderHistoryPage/collapsedImageGallery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ const CollapsedImageGallery = props => {
const baseImageElements = Object.values(items)
.slice(0, DISPLAY_COUNT)
.map((item, index) => {
if (!item) {
return null;
}
const { thumbnail, name } = item;
const { url } = thumbnail;

Expand Down