-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
J2D: Implement JSystem 2D rendering library, use it display Wind Waker place names #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can (hackily) be used to render a super basic pane
This is used by the message system, of which d_place_name is a part. In the future, I'll also use this for message dialogs during demos.
…-left, ours is bottom left. Place names are now in the correct positions
magcius
reviewed
Dec 13, 2024
Co-authored-by: Jasper St. Pierre <[email protected]>
…into placename
… to work with new ortho matrix Thanks to Jasper for setting me straight on where the Y inversion was coming from (J2DOrthoGraph::setPort())
magcius
requested changes
Dec 16, 2024
magcius
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/Common/JSYSTEM/J2D.ts
BLO
(Binary Layout).fopMsgM
functionality toframework.ts
src/ZeldaWindWaker/d_place_name.ts
BLO files contain layout data for 2D elements. It is made up of a hierarchy of J2DPanes (essentially just a bounding box) and J2Pictures. Child elements inherit the transform from their parents. The entire hierarchy contained in a single root J2DScreen object. I followed the pattern of J3D and split up the loading functions from the runtime objects.
J2D and BLO files can also be used to render message boxes during demos. I'm hoping that others will find uses for them as well.
As for place names: currently, the only ones that will display are Outset Island and The Forsaken Fortress during their intro cutscenes.