-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some extra features and fixed somes bugs #386
Open
meteor314
wants to merge
30
commits into
mafintosh:master
Choose a base branch
from
meteor314:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sheraff
suggested changes
Jun 20, 2022
Comment on lines
-2
to
18
"name": "peerflix", | ||
"name": "@meteor314/stream", | ||
"description": "Streaming torrent client for Node.js", | ||
"version": "0.39.0", | ||
"author": "Mathias Buus (@mafintosh)", | ||
"version": "1.0.5", | ||
"author": "@meteor314", | ||
"license": "MIT", | ||
"homepage": "https://github.com/mafintosh/peerflix", | ||
"homepage": "https://github.com/meteor314/stream", | ||
"main": "index.js", | ||
"bugs": { | ||
"url": "https://github.com/mafintosh/peerflix/issues" | ||
"url": "https://github.com/meteor314/stream/issues" | ||
}, | ||
"repository": { | ||
"type": "git", | ||
"url": "git://github.com/mafintosh/peerflix.git" | ||
"url": "git://github.com/meteor314/stream.git" | ||
}, | ||
"bin": { | ||
"peerflix": "./app.js" | ||
"stream": "app.js" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is fully appropriating the package, for a very small feature add. It smells like a hacking attempt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now you can see the remaining time for torrent download.
And also you can also see how many percentage of files you have downloaded, which files are downloaded and which ones are left to do.
Also I fixed the bug concerning the download for example
the command :
peerflix "torrent.torrent" --list
When you click on ctrl+c it is impossible to stop the script.