Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See output of external commands like --omx or --on-listening #222

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

manuhabitela
Copy link

Hey, thanks for peerflix which works incredibly well :)

I started to use it on a tiny project and stumbled upon something when using --omx or --on-listening: those external commands' outputs were not visible.

I figured it could be useful to have the output of those commands directly in the cli, so I changed the exec call for the omx, on-listening and on-downloaded options and replaced it with spawn (edit: I just changed those because they are the only ones I tested).

I did this mostly because when I want to use peerflix from a raspberry pi and omx, the omx keyboard shortcuts don't work with a simple exec.

What do you think?

this allows to have omx keyboard shortcuts working
this allows to see the output of given scripts directly
@mafintosh
Copy link
Owner

Doesn't this mess up the output when we're already drawing the peers you are connected to?

@manuhabitela
Copy link
Author

Gah, didn't see you answered :)

I guess it could mess up the output sometimes... Didn't bother me with --omx since it doesn't output lots of stuff and the video starts automatically anyway.

Maybe those options could check the --quiet option, and output things or not based on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants