Skip to content
This repository has been archived by the owner on Jun 2, 2019. It is now read-only.

Add support for older Puppet versions #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Garagoth
Copy link

Hi!

Had to add some tweaks to allow this provider to work on PE 2.8.x
If it passes your tests, could you please merge?

Regards,
Garagoth.

@carlossg
Copy link
Member

you would need to fix the tests too

  1) Puppet::Type::Maven::ProviderMvn#ensure= with ensure => present given a valid path when mvn returns 1 with no output
     Failure/Error: let(:output) { Puppet::Util::Execution::ProcessOutput.new '', 1 }
     NameError:
       uninitialized constant Puppet::Util::Execution::ProcessOutput
     # ./spec/unit/puppet/provider/maven/mvn_spec.rb:204:in `block (7 levels) in <top (required)>'
     # ./spec/unit/puppet/provider/maven/mvn_spec.rb:207:in `block (7 levels) in <top (required)>'

  2) Puppet::Type::Maven::ProviderMvn#ensure= with ensure => present given a valid path when mvn returns 1 with output "busted!"
     Failure/Error: let(:output) { Puppet::Util::Execution::ProcessOutput. new 'busted!', 1 }
     NameError:
       uninitialized constant Puppet::Util::Execution::ProcessOutput
     # ./spec/unit/puppet/provider/maven/mvn_spec.rb:213:in `block (7 levels) in <top (required)>'
     # ./spec/unit/puppet/provider/maven/mvn_spec.rb:217:in `block (7 levels) in <top (required)>'

@carlossg
Copy link
Member

Version v1.1.11 should work with puppet < 3.4.0

@carlossg
Copy link
Member

the change was introduced in #31

@Garagoth
Copy link
Author

#31 does not fix this. Let me fix those tests then, somehow I missed them.
EDIT: Uh, this requires to write new set of tests for Puppet that does not have Puppet::Util::Execution.
Currently I have no resources to do this, I'm sorry. Will try to get back to it then work permits.

@saliceti
Copy link

I am interested as well because I am stuck with 2.7.3 right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants