Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Silverstripe 5.x #30

Merged

Conversation

scott-nz
Copy link
Contributor

@scott-nz scott-nz commented Oct 27, 2023

Includes Unit test changes for PHPUnit 9.6

Note: #31 would need to be merged first to ensure proper Silverstripe 4 compatibility

@madmatt
Copy link
Owner

madmatt commented Oct 30, 2023

This looks good to me. It does mean that we are moving immediately from SS4 to SS5 compatibility which is fine but I suspect creating a 4 branch might be a good idea for a little while in case there are fixes required there.

I'm wanting to get GitHub Actions set up to run on all PRs etc to replace the in-project testing that was previously happening - @scott-nz if I gave you repo access would you be willing/able to set this up, or do you not have any time left for changes/updates?

Thanks!

@madmatt
Copy link
Owner

madmatt commented Oct 30, 2023

FYI this will resolve #29.

Includes Unit test changes for PHPUnit 9.6
@scott-nz scott-nz force-pushed the feature/silverstripe-5.x-compatibility branch from 8a3c6a5 to 2839e51 Compare October 30, 2023 02:24
@Firesphere
Copy link
Collaborator

This looks good to me. It does mean that we are moving immediately from SS4 to SS5 compatibility which is fine but I suspect creating a 4 branch might be a good idea for a little while in case there are fixes required there.

From what I can see, these changes do not break SS4, so there's no need to go to 5 immediately?

Haven't extensively tested though.

@madmatt
Copy link
Owner

madmatt commented Oct 30, 2023

In that case, maybe a simple ^4|^5 in the composer.json might be okay, with a matching Readme update? I haven't tested this on SS4 yet so can't confirm right away - perhaps you might know @scott-nz?

@edwilde
Copy link
Collaborator

edwilde commented Sep 10, 2024

Unless anyone has any objections, I will merge and release this as v2.0.0 on Friday 13 😬 September

@edwilde edwilde merged commit e86ead4 into madmatt:main Sep 12, 2024
7 checks passed
@edwilde edwilde deleted the feature/silverstripe-5.x-compatibility branch September 12, 2024 22:08
@edwilde edwilde restored the feature/silverstripe-5.x-compatibility branch September 12, 2024 22:09
@madmatt
Copy link
Owner

madmatt commented Sep 13, 2024

👻 Thanks Ed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants