-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for Silverstripe 5.x #30
Updates for Silverstripe 5.x #30
Conversation
This looks good to me. It does mean that we are moving immediately from SS4 to SS5 compatibility which is fine but I suspect creating a I'm wanting to get GitHub Actions set up to run on all PRs etc to replace the in-project testing that was previously happening - @scott-nz if I gave you repo access would you be willing/able to set this up, or do you not have any time left for changes/updates? Thanks! |
FYI this will resolve #29. |
Includes Unit test changes for PHPUnit 9.6
8a3c6a5
to
2839e51
Compare
From what I can see, these changes do not break SS4, so there's no need to go to 5 immediately? Haven't extensively tested though. |
In that case, maybe a simple |
Unless anyone has any objections, I will merge and release this as |
👻 Thanks Ed! |
Includes Unit test changes for PHPUnit 9.6
Note: #31 would need to be merged first to ensure proper Silverstripe 4 compatibility