Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

router.js - Updating require path for buildModule #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

router.js - Updating require path for buildModule #7

wants to merge 2 commits into from

Conversation

jtabalujan2
Copy link

@jtabalujan2 jtabalujan2 commented Nov 7, 2020 •
edited
Loading

  • Updated conf require statement to handle both ES6 (export default) and CommonJS (module.exports)

@jtabalujan2
Update router.js
3f5080f 
Removing .default since the path does not exist within nuxt config
@jtabalujan2
Update router.js
78d0dae 
Added optional chaining to let it load as an undefined
@jtabalujan2
Copy link
Author

@madhusudanbabar could you merge this?

@madhusudanbabar
Copy link
Owner

Yes, I was waiting for the some other changes but will merge this one and optional chaining for the paths and release an update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtabalujan2 @madhusudanbabar