Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ⚰️ remove dead code in Struct Starknet<..> #76

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

jbcaron
Copy link
Member

@jbcaron jbcaron commented Apr 25, 2024

remove dead code in Struct Starknet<..>

Pull Request type

  • Refactoring (no functional changes, no API changes)

What is the current behavior?

What is the new behavior?

  • remove fields for Struct Starknet<..>:
    • pool
    • graph
    • genesis_provider

Does this introduce a breaking change?

No

Other information

remove fields pool, graph and genesis_provider
@jbcaron jbcaron requested review from Trantorian1 and antiyro April 25, 2024 13:45
@jbcaron jbcaron self-assigned this Apr 25, 2024
@jbcaron jbcaron requested a review from Tbelleng April 25, 2024 14:31
Copy link
Collaborator

@Trantorian1 Trantorian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good, great work? Been looking forwards to this for a long time haha 🙏

Copy link
Contributor

@Tbelleng Tbelleng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done Charpa, no more dead code 🕊️

@jbcaron jbcaron merged commit 33dc83d into madara-alliance:main Apr 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants